[
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267173#comment-15267173
]
ASF GitHub Bot commented on CLOUDSTACK-9299:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61778682
--- Diff:
api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java
---
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.outofbandmanagement;
+
+import com.cloud.dc.DataCenter;
+import com.cloud.host.Host;
+import com.cloud.org.Cluster;
+import com.google.common.collect.ImmutableMap;
+import org.apache.cloudstack.api.response.OutOfBandManagementResponse;
+import org.apache.cloudstack.framework.config.ConfigKey;
+
+import java.util.List;
+
+public interface OutOfBandManagementService {
+
+ ConfigKey<Long> OutOfBandManagementActionTimeout = new
ConfigKey<Long>("Advanced", Long.class, "outofbandmanagement.action.timeout",
"60",
+ "The out of band management action timeout in seconds,
configurable by cluster", true, ConfigKey.Scope.Cluster);
+
+ ConfigKey<Long> OutOfBandManagementSyncThreadInterval = new
ConfigKey<Long>("Advanced", Long.class, "outofbandmanagement.sync.interval",
"300000",
+ "The interval (in milliseconds) when the out-of-band
management background sync are retrieved", true, ConfigKey.Scope.Global);
+
+ ConfigKey<Integer> OutOfBandManagementSyncThreadPoolSize = new
ConfigKey<Integer>("Advanced", Integer.class,
"outofbandmanagement.sync.poolsize", "50",
+ "The out of band management background sync thread pool size",
true, ConfigKey.Scope.Global);
+
+ long getId();
+ boolean isOutOfBandManagementEnabled(Host host);
+ void submitBackgroundPowerSyncTask(Host host);
+ boolean transitionPowerStateToDisabled(List<? extends Host> hosts);
+
+ OutOfBandManagementResponse
enableDisableOutOfBandManagement(DataCenter zone, boolean enabled);
+ OutOfBandManagementResponse enableDisableOutOfBandManagement(Cluster
cluster, boolean enabled);
+ OutOfBandManagementResponse enableDisableOutOfBandManagement(Host
host, boolean enabled);
--- End diff --
Why not name these methods either ``enableOutOfBandManagement`` or
``disableOutOfBandManagement``? The naming seems ambiguous as it does not
indicate what a ``true`` or ``false`` value means for the ``enabled`` parameter.
> Out-of-band Management for CloudStack
> -------------------------------------
>
> Key: CLOUDSTACK-9299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rohit Yadav
> Assignee: Rohit Yadav
> Fix For: 4.9.0, Future
>
>
> Support access to a host’s out-of-band management interface (e.g. IPMI, iLO,
> DRAC, etc.) to manage host power operations (on/off etc.) and querying
> current power state.
> FS:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
