[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270557#comment-15270557
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8901:
--------------------------------------------

Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/880#issuecomment-216847988
  
    LGTM. Verified that a configuration entry is added with default 8 as pool 
size. Increased the default threadpool size, restarted MS and verified that 
when multiple prepareTemplate APIs are invoked required number of threads gets 
created.
    
    INFO  [c.c.t.TemplateManagerImpl] (Template-Preloader-11:ctx-9cefa1ea) 
(logid:49186ba8) Start to preload template 201 into primary storage 2
    INFO  [c.c.t.TemplateManagerImpl] (Template-Preloader-12:ctx-601679be) 
(logid:1ea23b56) Start to preload template 201 into primary storage 3



> PrepareTemplate job thread hard-coded to max 8 threads
> ------------------------------------------------------
>
>                 Key: CLOUDSTACK-8901
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8901
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: sudharma jain
>
>  The thread pool is hardcoded to use 8 threads,
> com.cloud.template.TemplateManagerImpl.configure(String, Map<String, Object>):
> _preloadExecutor = Executors.newFixedThreadPool(8, new 
> NamedThreadFactory("Template-Preloader"));
> Need to make it configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to