[ https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270703#comment-15270703 ]
ASF subversion and git services commented on CLOUDSTACK-8302: ------------------------------------------------------------- Commit c9319e21fb33eaab42dee90cbfedd88eff23e842 in cloudstack's branch refs/heads/master from [~williamstev...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c9319e2 ] Merge pull request #1230 from SafeSwissCloud/CLOUDSTACK-8302 CLOUDSTACK-8302: Removing snapshots on RBDSnapshot removing implemented if primary datastore is RBD https://issues.apache.org/jira/browse/CLOUDSTACK-8302 * pr/1230: CLOUDSTACK-8302 - Cleanup snapshot on KVM with RBD Snapshot removing implemented on RBD. 1. On management side: when created new shanpshot we checking if our primary storage is RBD, then do not remove record from cloud.snapshot_store_ref with link to Ceph image via 'install_path' field. 2. On management side: when removing snapshot, also send command to agent 'DeleteCommand'. 3. On agent side: method implemented 'public Answer deleteSnapshot(final DeleteCommand cmd)' Signed-off-by: Will Stevens <williamstev...@gmail.com> > Cleanup snapshot on KVM with RBD > -------------------------------- > > Key: CLOUDSTACK-8302 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Snapshot, Storage Controller > Affects Versions: 4.4.0, 4.4.1, 4.4.2 > Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8 > Reporter: Star Guo > Assignee: Wido den Hollander > Priority: Critical > > I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8. > I deploy an instance on RBD and I create the ROOT volume snapshots. When > delete a snapshot the UI show OK, but the snapshot of the volume in the RBD > pool is still exist. > And I find the code in > com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: > … > @Override > public Answer deleteSnapshot(DeleteCommand cmd) { > return new Answer(cmd); > } > … > deleteSnapshot() does not be implememented. And I also find the code: > ... > @Override > public Answer createTemplateFromSnapshot(CopyCommand cmd) { > return null; //To change body of implemented methods use File | > Settings | File Templates. > } > ... > So does createTenokateFromSnapshot(). I just look for it in MASTER branch but > not do that yet. Will CloudStack Dev Team plan to do that ? Thanks . -- This message was sent by Atlassian JIRA (v6.3.4#6332)