[
https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272918#comment-15272918
]
ASF GitHub Bot commented on CLOUDSTACK-9348:
--------------------------------------------
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217252920
@rhtyd I have some bad news on this PR. I have been having issues in CI
ever since this got merged into master. When the tests don't run (and fail
which causes the CI run to fail), then the DeployDatacenter script will fail.
It looks like this code is treating the hosts as a malicious client. We get a
handshake and then things fail. We basically get a `Failed to add host` error.
I can get you more details if you need.
I will test the #1534 PR to see if that fixes things, but I am a bit
concerned about this PR right now...
> CloudStack Server degrades when a lot of connections on port 8250
> -----------------------------------------------------------------
>
> Key: CLOUDSTACK-9348
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rohit Yadav
> Assignee: Rohit Yadav
> Fix For: 4.9.0
>
>
> An intermittent issue was found with a large CloudStack deployment, where
> servers could not keep agents connected on port 8250.
> All connections are handled by accept() in NioConnection:
> https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125
> A new connection is handled by accept() which does blocking SSL handshake. A
> good fix would be to make this non-blocking and handle expensive tasks in
> separate threads/pool. This way the main IO loop won't be blocked and can
> continue to serve other agents/clients.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
