[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273963#comment-15273963
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9299:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1502#discussion_r62321985
  
    --- Diff: server/src/com/cloud/server/StatsCollector.java ---
    @@ -412,6 +428,36 @@ protected void runInContext() {
             }
         }
     
    +    class HostOutOfBandManagementStatsCollector extends 
ManagedContextRunnable {
    +        @Override
    +        protected void runInContext() {
    +            try {
    +                s_logger.debug("HostOutOfBandManagementStatsCollector is 
running...");
    +                List<OutOfBandManagementVO> outOfBandManagementHosts = 
outOfBandManagementDao.findAllByManagementServer(ManagementServerNode.getManagementServerId());
    +                if (outOfBandManagementHosts == null) {
    +                    return;
    +                }
    +                for (OutOfBandManagement outOfBandManagementHost : 
outOfBandManagementHosts) {
    +                    Host host = 
_hostDao.findById(outOfBandManagementHost.getHostId());
    +                    if (host == null) {
    +                        continue;
    +                    }
    +                    if 
(outOfBandManagementService.isOutOfBandManagementEnabled(host)) {
    +                        
outOfBandManagementService.submitBackgroundPowerSyncTask(host);
    +                    } else {
    +                        if (outOfBandManagementHost.getPowerState() != 
OutOfBandManagement.PowerState.Disabled) {
    +                            if 
(outOfBandManagementService.transitionPowerStateToDisabled(Collections.singletonList(host)))
 {
    +                                s_logger.debug("Out-of-band management was 
disabled in zone/cluster/host, disabled power state for host id:" + 
host.getId());
    --- End diff --
    
    Please wrap in a ``if (LOGGER.isDebugEnabled)`` check.


> Out-of-band Management for CloudStack
> -------------------------------------
>
>                 Key: CLOUDSTACK-9299
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: 4.9.0, Future
>
>
> Support access to a host’s out-of-band management interface (e.g. IPMI, iLO, 
> DRAC, etc.) to manage host power operations (on/off etc.) and querying 
> current power state.
> FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)