[
https://issues.apache.org/jira/browse/CLOUDSTACK-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274186#comment-15274186
]
ASF GitHub Bot commented on CLOUDSTACK-6975:
--------------------------------------------
Github user dsclose commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1514#discussion_r62344011
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -54,7 +54,8 @@ def process(self):
self.cloud.commit()
# We restart DNSMASQ every time the configure.py is called in
order to avoid lease problems.
- CsHelper.service("dnsmasq", "restart")
+ if not self.cl.is_redundant() or self.cl.is_master():
--- End diff --
@jburwell Whilst that check might be convenient in some cases, I think that
convenience would be a curse. For example "bring up dnsmasq on non-redundant or
master routers" is a nice explicit declaration of behaviour. Simplifying that
to "bring up dnsmasq on master routers" might do the same thing but it
increases the learning curve for someone reading the code for the first time.
> Service monitoring starts dnsmasq on backup router when using redundant VRs
> ---------------------------------------------------------------------------
>
> Key: CLOUDSTACK-6975
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6975
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.3.0
> Environment: KVM
> Reporter: Magnus Bengtsson
>
> When using a network offering with redundant routers the default setting of
> EnableServiceMonitoring enables monit on the routers.
> "network.router.EnableServiceMonitoring service monitoring in router
> enable/disable option, default true false"
> This causes monit to run dnsmasq on both the Master and Backup router. When
> the backup router assigns dhcp to clients, password and userdata retrieval
> from that node fails since the services are not running on the backup router.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
