[
https://issues.apache.org/jira/browse/CLOUDSTACK-9199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276250#comment-15276250
]
ASF GitHub Bot commented on CLOUDSTACK-9199:
--------------------------------------------
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-217842674
as @pedro-martins stated, it seems to be fitting that this method is
extracted to a class to be documented/tested. The code looks good but if the
exception is to be launched I see no room for backward compatibility. If that's
an issue, this needs to be rethinked as the raised exception would have to be
treated and at that point we would have to think if raising the exception was
really necessary. Overall the code looks good, simple and justified.
> deployVirtualMachine API does not throw an error when cpunumber is specified
> for static compute offering
> --------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9199
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Anshul Gangwar
> Assignee: Anshul Gangwar
>
> When a dynamic compute offering is chosen, deployVirtualMachine API requires
> details[0].cpuSpeed, details[0].cpuNumber and details[0]memory parameters to
> deploy a VM.
> But when a static compute offering is chosen and these parameters are
> provided, then the API should throw an error as there is conflict.
> ACTUAL BEHAVIOR :
> VM is getting deployed with static compute offering's parameters
> http://10.220.135.6/client/api?command=deployVirtualMachine&name=olotwo&response=&zoneid=ab6e4154-62a3-42a8-9627-3cbdc66bcbb6&templateid=3aaaace6-91b4-11e5-b6fc-e26c2aa1d1d0&hypervisor=XenServer&serviceofferingid=39643075-4b45-489d-afac-88f09d536bdd&details[0].cpuNumber=1&details[0].cpuSpeed=1000&details[0].memory=1000&securitygroupids=60844698-91b4-11e5-b6fc-e26c2aa1d1d0&_=1448277187743
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
