[
https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285335#comment-15285335
]
ASF GitHub Bot commented on CLOUDSTACK-9348:
--------------------------------------------
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-219551825
I think I am going to have to revert this PR because it seems to be
responsible for the `addHost` issue I am having in all my CI environments while
doing DeployDC. On completely new deployments, I got the `addHost` error on
all 6 of my CI environments with #1493 included. I have noticed this as an
intermittent issue for the last while, but could not isolate it.
I have reverted #1493 (and it's descendants) locally and I have not had the
error in my first 3 tests after reverting it. I only started seeing the
problem after #1493.
With the freeze basically here, I need my CI environments in action cause I
have a few PRs that I really want to run before I merge and freeze...
This is what I plan to run to revert (brackets are for reference, not to be
run):
```
git revert 540d9572fd491db3ce182d26636fc74ada4e171c (1543)
git revert f88cb880974fa56866492c437af291e40bd1a4f6 -m 1 (1538)
git revert 9f970f28b18534dffe33196ead60ea861f501fa9 -m 1 (1534)
git revert 7ce0e10fbcd949375e43535aae168421ecdaa562 -m 1 (1493)
```
> CloudStack Server degrades when a lot of connections on port 8250
> -----------------------------------------------------------------
>
> Key: CLOUDSTACK-9348
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rohit Yadav
> Assignee: Rohit Yadav
> Fix For: 4.9.0
>
>
> An intermittent issue was found with a large CloudStack deployment, where
> servers could not keep agents connected on port 8250.
> All connections are handled by accept() in NioConnection:
> https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125
> A new connection is handled by accept() which does blocking SSL handshake. A
> good fix would be to make this non-blocking and handle expensive tasks in
> separate threads/pool. This way the main IO loop won't be blocked and can
> continue to serve other agents/clients.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
