[
https://issues.apache.org/jira/browse/CLOUDSTACK-9203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294477#comment-15294477
]
ASF GitHub Bot commented on CLOUDSTACK-9203:
--------------------------------------------
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1297
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9203
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1297
----
commit 0d02a778fa89a175a5e1869766202f2308f23fcf
Author: Loic Lambiel <l...@exoscale.ch>
Date: 2015-05-15T13:15:26Z
CLOUDSTACK-9203 Prevent security group update while instance is running
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
commit aa72dbd814de4ea88f1835a3eb99053082a2e84c
Author: Daan Hoogland <d...@onecht.net>
Date: 2015-12-30T12:13:38Z
CLOUDSTACK-9203 refactorred DeployVM code to be used by UpdateVM as well
Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
commit f72c8f23b4acccc35bea10455e70dbc30afeee29
Author: Daan Hoogland <d...@onecht.net>
Date: 2015-12-30T12:13:38Z
CLOUDSTACK-9203 refactorred DeployVM code to be used by UpdateVM as well
Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
commit 659f527095fe24f55cbe2a73ecbe6eec31714052
Author: Wei Zhou <w.z...@tech.leaseweb.com>
Date: 2016-01-12T09:56:07Z
CLOUDSTACK-9203: fix issue if there are multiple shared networks
commit 64e5792d347540df505dff88087a33d8d62bc0e4
Author: Wei Zhou <w.z...@tech.leaseweb.com>
Date: 2016-01-22T11:45:13Z
CLOUDSTACK-9203: fix issue when update vm in isolated networks
commit acf0213f1cee740ec9ff6c9df902ab5a64adb922
Author: Daan Hoogland <d...@onecht.net>
Date: 2016-04-11T18:22:34Z
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java
commit 976feb31862b5b17f3a3d139bd348ac501cc512b
Author: Daan Hoogland <d...@onecht.net>
Date: 2016-04-11T18:22:34Z
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java
----
> [API] extend updateVirtualMachine to support updating security groups
> ---------------------------------------------------------------------
>
> Key: CLOUDSTACK-9203
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9203
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Reporter: René Moser
> Assignee: Daan Hoogland
> Priority: Minor
> Fix For: Future
>
>
> There is currently no way to change security groups on exisitng VMs.
> {{updateVirtualMachine}} should be extended in a similar way as
> {{deployVirtualMachine}} which should allow passing a list of IDs or names to
> update the security groups as passed:
> {{securitygroupids}} parameter
> comma separated list of security groups id that going to be applied to the
> virtual machine. Should be passed only when vm is created from a zone with
> Basic Network support. Mutually exclusive with securitygroupnames parameter,
> default: false
> {{securitygroupnames}} parameter
> comma separated list of security groups names that going to be applied to the
> virtual machine. Should be passed only when vm is created from a zone with
> Basic Network support. Mutually exclusive with securitygroupids parameter.
> default: false
> Exoscale did already some work in their branch which we are
> [allowed|https://twitter.com/resmo79/status/681428989018267648] to use, see
> [https://github.com/exoscale/cloudstack/pull/6/]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
