[ https://issues.apache.org/jira/browse/CLOUDSTACK-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323850#comment-15323850 ]
ASF GitHub Bot commented on CLOUDSTACK-9389: -------------------------------------------- Github user nitt10prashant commented on the issue: https://github.com/apache/cloudstack/pull/1563 @swill just curious to know Which guest OS you are using ? Since Cent OS template is default in ACS i modified test_data for cent OS. Regx should be consider ? ->I Agree with you, will push changes for regx to make sure it work for both ping pattern . What do you think? Sorry, I don't mean to be combative here, but this is a good opertunity for us to review the way we handle OS specific test data. ->Yes this should be discussed thoroughly and should be documented properly > [Automation ]modifying integration/smoke/test_routers_network_ops.py > -------------------------------------------------------------------- > > Key: CLOUDSTACK-9389 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9389 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation > Reporter: prashant kumar mishra > Assignee: prashant kumar mishra > > Some test cases were failing due to invalid check_string , proposing > following modifications > 1-Moving check_string to test_data.py > 2-Since ping cmd reply is OS dependent ,for default templates os type > CentOS changing check_string from "3 packets received" to "3 received" > [root@BPKxDmS ~]# ping -c 3 8.8.8.8 > PING 8.8.8.8 (8.8.8.8) 56(84) bytes of data. > 64 bytes from 8.8.8.8: icmp_seq=1 ttl=52 time=16.9 ms > 64 bytes from 8.8.8.8: icmp_seq=2 ttl=52 time=16.7 ms > 64 bytes from 8.8.8.8: icmp_seq=3 ttl=52 time=17.0 ms > --- 8.8.8.8 ping statistics --- > 3 packets transmitted, 3 received, 0% packet loss, time 2020ms > rtt min/avg/max/mdev = 16.720/16.896/17.015/0.196 ms -- This message was sent by Atlassian JIRA (v6.3.4#6332)