[
https://issues.apache.org/jira/browse/CLOUDSTACK-9402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359305#comment-15359305
]
ASF GitHub Bot commented on CLOUDSTACK-9402:
--------------------------------------------
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@remibergsma As a common team practice, we just happened to agree upon with
this line length :). Agree, we should make our Marvin code truly PEP8 compliant
as you suggested, and update our Marvin code accordingly.
I ran all our Marvin tests with this PR as it involves Nuage VSP support
for underlay networking besides our default overlay networking. Moreover, we
perform quite a few VM deployments (reboots, migrations, expunges, etc.) and
traffic tests (e.g. SSH into VM and then wget from the Internet) in these
tests. Finally, the CentOS guest VM template that we use for our internal
regressions takes a bit longer to start/stop guest VMs (rich feature set and
programmes).
Here are some metrics:
VM deployements: 63
Isolated network creations: 57
SSH into VMs (reconnects) = 82
Note: Unless required, we don't always run all of our Marvin tests in a
single Marvin run.
Anyhow, we actively use nosetests features such as tags/attributes to run
subset of these tests in the following scenarios:
1) simulator tests (required hardware=false)
2) feature specific tests
3) basic (smoke) tests
4) E2E (traffic) tests
Note: Once we have considerable number of tests in our plugins/nuagevsp
directory, we are also thinking about creating sub-directories as well (e.g.
component, smoke, etc.).
Let me know, your thoughts on this, and if you have any other questions for
me.
Thank you for your valuable review and suggestions !!
> Nuage VSP Plugin : Support for underlay features (Source & Static NAT to
> underlay) including Marvin test coverage on master
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9402
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9402
> Project: CloudStack
> Issue Type: Task
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Automation, Network Controller
> Reporter: Mani Prashanth Varma Manthena
> Assignee: Nick Livens
> Fix For: 4.9.0
>
>
> Support for underlay features (Source & Static NAT to underlay) with Nuage
> VSP SDN Plugin including Marvin test coverage for corresponding Source &
> Static NAT features on master. Moreover, our Marvin tests are written in such
> a way that they can validate our supported feature set with both Nuage VSP
> SDN platform's overlay and underlay infra.
> PR contents:
> 1) Support for Source NAT to underlay feature on master with Nuage VSP SDN
> Plugin.
> 2) Support for Static NAT to underlay feature on master with Nuage VSP SDN
> Plugin.
> 3) Marvin test coverage for Source & Static NAT to underlay on master with
> Nuage VSP SDN Plugin.
> 4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
> 5) PEP8 & PyFlakes compliance with our Marvin test code.
> Our Marvin test code PEP8 & PyFlakes compliance:
> CloudStack$
> CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py
> CloudStack$
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
> CloudStack$
> Validations:
> 1) Underlay infra (Source & Static NAT to underlay)
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg
> plugins/nuagevsp/test_nuage_source_nat.py
> Test results:
> Test Nuage VSP Isolated networks with different combinations of Source NAT
> service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks
> | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC networks with different combinations of Source NAT service
> providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status :
> SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality for Isolated network by performing
> (wget) traffic tests to the ... === TestName:
> test_03_nuage_SourceNAT_isolated_network_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality for VPC network by performing (wget)
> traffic tests to the Internet ... === TestName:
> test_04_nuage_SourceNAT_vpc_network_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with different Egress
> Firewall/Network ACL rules by performing (wget) ... === TestName:
> test_05_nuage_SourceNAT_acl_rules_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with VM NIC operations by performing
> (wget) traffic tests to the ... === TestName:
> test_06_nuage_SourceNAT_vm_nic_operations_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with VM migration by performing
> (wget) traffic tests to the Internet ... === TestName:
> test_07_nuage_SourceNAT_vm_migration_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality with network restarts by performing
> (wget) traffic tests to the ... === TestName:
> test_08_nuage_SourceNAT_network_restarts_traffic | Status : SUCCESS ===
> ok
> ----------------------------------------------------------------------
> Ran 8 tests in 13360.858s
> OK
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg
> plugins/nuagevsp/test_nuage_static_nat.py
> Test results:
> Test Nuage VSP Public IP Range creation and deletion ... === TestName:
> test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS ===
> ok
> Test Nuage VSP Nuage Underlay (underlay networking) enabled Public IP Range
> creation and deletion ... === TestName:
> test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS ===
> ok
> Test Nuage VSP Isolated networks with different combinations of Static NAT
> service providers ... === TestName: test_03_nuage_StaticNAT_isolated_networks
> | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC networks with different combinations of Static NAT service
> providers ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status :
> SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality for Isolated network by performing
> (wget) traffic tests to the ... === TestName:
> test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality for VPC network by performing (wget)
> traffic tests to the Internet ... === TestName:
> test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality with different Egress
> Firewall/Network ACL rules by performing (wget) ... === TestName:
> test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality with VM NIC operations by performing
> (wget) traffic tests to the ... === TestName:
> test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality with VM migration by performing
> (wget) traffic tests to the Internet ... === TestName:
> test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality with network restarts by performing
> (wget) traffic tests to the ... === TestName:
> test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS ===
> ok
> ----------------------------------------------------------------------
> Ran 10 tests in 9472.468s
> OK
> 2) Overlay Infra (Source & Static NAT to overlay)
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg
> plugins/nuagevsp/test_nuage_source_nat.py
> Test results:
> Test Nuage VSP Isolated networks with different combinations of Source NAT
> service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks
> | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC networks with different combinations of Source NAT service
> providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status :
> SUCCESS ===
> ok
> Test Nuage VSP Source NAT functionality for Isolated network by performing
> (wget) traffic tests to the ... SKIP: Configured Nuage VSP SDN platform
> infrastructure does not support underlay networking: skipping test
> Test Nuage VSP Source NAT functionality for VPC network by performing (wget)
> traffic tests to the Internet ... SKIP: Configured Nuage VSP SDN platform
> infrastructure does not support underlay networking: skipping test
> Test Nuage VSP Source NAT functionality with different Egress
> Firewall/Network ACL rules by performing (wget) ... SKIP: Configured Nuage
> VSP SDN platform infrastructure does not support underlay networking:
> skipping test
> Test Nuage VSP Source NAT functionality with VM NIC operations by performing
> (wget) traffic tests to the ... SKIP: Configured Nuage VSP SDN platform
> infrastructure does not support underlay networking: skipping test
> Test Nuage VSP Source NAT functionality with VM migration by performing
> (wget) traffic tests to the Internet ... SKIP: Configured Nuage VSP SDN
> platform infrastructure does not support underlay networking: skipping test
> Test Nuage VSP Source NAT functionality with network restarts by performing
> (wget) traffic tests to the ... SKIP: Configured Nuage VSP SDN platform
> infrastructure does not support underlay networking: skipping test
> ----------------------------------------------------------------------
> Ran 8 tests in 1213.858s
> OK (SKIP=6)
> Marvin test run:
> nosetests --with-marvin --marvin-config=nuage.cfg
> plugins/nuagevsp/test_nuage_static_nat.py
> Test results:
> Test Nuage VSP Public IP Range creation and deletion ... === TestName:
> test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS ===
> ok
> Test Nuage VSP Nuage Underlay (underlay networking) enabled Public IP Range
> creation and deletion ... === TestName:
> test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS ===
> ok
> Test Nuage VSP Isolated networks with different combinations of Static NAT
> service providers ... === TestName: test_03_nuage_StaticNAT_isolated_networks
> | Status : SUCCESS ===
> ok
> Test Nuage VSP VPC networks with different combinations of Static NAT service
> providers ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status :
> SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality for Isolated network by performing
> (wget) traffic tests to the ... === TestName:
> test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality for VPC network by performing (wget)
> traffic tests to the Internet ... === TestName:
> test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality with different Egress
> Firewall/Network ACL rules by performing (wget) ... === TestName:
> test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality with VM NIC operations by performing
> (wget) traffic tests to the ... === TestName:
> test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality with VM migration by performing
> (wget) traffic tests to the Internet ... === TestName:
> test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS ===
> ok
> Test Nuage VSP Static NAT functionality with network restarts by performing
> (wget) traffic tests to the ... === TestName:
> test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS ===
> ok
> ----------------------------------------------------------------------
> Ran 10 tests in 8972.563s
> OK
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
