[ https://issues.apache.org/jira/browse/CLOUDSTACK-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415716#comment-15415716 ]
ASF GitHub Bot commented on CLOUDSTACK-9422: -------------------------------------------- Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1602#discussion_r74301008 --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageSubsystemCommandHandler.java --- @@ -66,19 +68,28 @@ public VmwareStorageSubsystemCommandHandler(StorageProcessor processor, Integer this._nfsVersion = nfsVersion; } - /** - * Reconfigure NFS version for storage operations - * @param nfsVersion NFS version to set - * @return true if NFS version could be configured, false in other case - */ - public boolean reconfigureNfsVersion(Integer nfsVersion){ + public boolean reconfigureStorageProcessor(EnumMap<VmwareStorageProcessorConfigurableFields,Object> params) { + VmwareStorageProcessor processor = (VmwareStorageProcessor) this.processor; try { - VmwareStorageProcessor processor = (VmwareStorageProcessor) this.processor; - processor.setNfsVersion(nfsVersion); - this._nfsVersion = nfsVersion; + for (VmwareStorageProcessorConfigurableFields key : params.keySet()){ + switch (key){ + case NFS_VERSION: + Integer nfsVersion = (Integer) params.get(key); + processor.setNfsVersion(nfsVersion); + this._nfsVersion = nfsVersion; + break; + case FULL_CLONE_FLAG: + boolean fullClone = (boolean) params.get(key); + processor.setFullCloneFlag(fullClone); + break; + default: + String msg = "Unknown reconfigurable field " + key.getName() + " for VmwareStorageProcessor"; + throw new IllegalStateException(msg); + } + } return true; - } catch (Exception e){ - s_logger.error("Error while reconfiguring NFS version " + nfsVersion); + } catch (IllegalStateException e){ --- End diff -- Ok, thanks > Granular VMware vm's creation as full clones on HV > -------------------------------------------------- > > Key: CLOUDSTACK-9422 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9422 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VMware > Reporter: Nicolas Vazquez > Assignee: Nicolas Vazquez > > h3. Introduction > For VMware, It is possible to decide creating VMs as full clones on ESX HV, > adjusting {{vmware.create.full.clone}} global setting. We would like to > introduce this property as a primary storage detail, and use its value > instead of global setting's value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)