[ https://issues.apache.org/jira/browse/CLOUDSTACK-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417570#comment-15417570 ]
ASF GitHub Bot commented on CLOUDSTACK-9379: -------------------------------------------- Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1542 @nvazquez the code is great now. I have just a concern about that hack to change the field declared as final. In my opinion, the final there does not bring benefits. So, I believe it can be removed. I have seen people using final a lot, but I think that final should be used only when we have 100% certainty that it is needed; otherwise, it complicates our lives when writing test cases or while extending some method/class. What do you think? > Support nested virtualization at VM level on VMware Hypervisor > -------------------------------------------------------------- > > Key: CLOUDSTACK-9379 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9379 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VMware > Affects Versions: 4.9.0 > Reporter: Nicolas Vazquez > Assignee: Nicolas Vazquez > > h2. Introduction > It is desired to support nested virtualization at VM level for VMware > hypervisor. Current behaviour supports enabling/desabling global nested > virtualization by modifying global config {{'vmware.nested.virtualization'}}. > It is wished to improve this feature, having control at VM level instead of a > global control only. > h2. Proposal > A new global configuration is added, to enable/disable VM nested > virtualization control: {{'vmware.nested.virtualization.perVM'}}. Default > value=false > h2. Behaviour > After a vm deployment or start command, vm params include > {{nestedVirtualizationFlag}} key and its value is: > * true -> nested virtualization enabled > * false -> nested virtualization disabled > We will determinate nested virtualization enabled/disabled by examining: > * (1) global configuration {{'vmware.nested.virtualization'}} value > * (2) global configuration {{'vmware.nested.virtualization.perVM'}} value > * (3) {{'nestedVirtualizationFlag'}} value in {{user_vm_details}} if present, > null if not. > Using this 3 values, there are different use cases: > # (1) = TRUE, (2) = TRUE, (3) is null -> ENABLED > # (1) = TRUE, (2) = TRUE, (3) = TRUE -> ENABLED > # (1) = TRUE, (2) = TRUE, (3) = FALSE -> DISABLED > # (1) = TRUE, (2) = FALSE -> ENABLED > # (1) = FALSE, (2) = TRUE, (3) is null -> DISABLED > # (1) = FALSE, (2) = TRUE, (3) = TRUE -> ENABLED > # (1) = FALSE, (2) = TRUE, (3) = FALSE -> DISABLED > # (1) = FALSE, (2) = FALSE -> DISABLED -- This message was sent by Atlassian JIRA (v6.3.4#6332)