[ https://issues.apache.org/jira/browse/CLOUDSTACK-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469421#comment-15469421 ]
ASF GitHub Bot commented on CLOUDSTACK-9401: -------------------------------------------- Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1578#discussion_r77756212 --- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py --- @@ -175,45 +234,44 @@ def tearDown(self): return # create_VpcOffering - Creates VPC offering - def create_VpcOffering(self, vpc_offering, suffix=None): - self.debug("Creating VPC offering") + @needscleanup + def create_VpcOffering(cls, vpc_offering, suffix=None): + cls.debug("Creating VPC offering") if suffix: vpc_offering["name"] = "VPC_OFF-" + str(suffix) - vpc_off = VpcOffering.create(self.api_client, + vpc_off = VpcOffering.create(cls.api_client, vpc_offering ) # Enable VPC offering - vpc_off.update(self.api_client, state="Enabled") - self.cleanup.append(vpc_off) - self.debug("Created and Enabled VPC offering") + vpc_off.update(cls.api_client, state="Enabled") + cls.debug("Created and Enabled VPC offering") return vpc_off # create_Vpc - Creates VPC with the given VPC offering - def create_Vpc(self, vpc_offering, cidr='10.1.0.0/16', testdata=None, account=None, networkDomain=None, - cleanup=True): + @needscleanup + def create_Vpc(cls, vpc_offering, cidr='10.1.0.0/16', testdata=None, + account=None, networkDomain=None): if not account: - account = self.account - self.debug("Creating a VPC in the account - %s" % account.name) + account = cls.account + cls.debug("Creating a VPC in the account - %s" % account.name) if not testdata: - testdata = self.test_data["vpc"] + testdata = cls.test_data["vpc"] testdata["name"] = "TestVPC-" + cidr + "-" + str(vpc_offering.name) testdata["displaytext"] = "Test VPC" testdata["cidr"] = cidr - vpc = VPC.create(self.api_client, + vpc = VPC.create(cls.api_client, testdata, vpcofferingid=vpc_offering.id, - zoneid=self.zone.id, + zoneid=cls.zone.id, account=account.name, domainid=account.domainid, networkDomain=networkDomain ) - self.debug("Created VPC with ID - %s" % vpc.id) - if cleanup: - self.cleanup.append(vpc) + cls.debug("Created VPC with ID - %s" % vpc.id) return vpc # restart_Vpc - Restarts the given VPC with/without cleanup - def restart_Vpc(self, vpc, cleanup=None): + def restart_Vpc(self, vpc, cleanup=False): --- End diff -- Flag arguments are an anti-pattern. Please consider refactoring to another method such as ``restartVpcWithCleanup``. > Nuage VSP Plugin : Support for InternalDns including Marvin test coverage > ------------------------------------------------------------------------- > > Key: CLOUDSTACK-9401 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9401 > Project: CloudStack > Issue Type: Task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation, Network Controller > Reporter: Rahul Singal > Assignee: Nick Livens > > Supporting Internal Dns by using Dns service provider as Virtual Router but > Dhcp provider will be NuageVsp. The idea is here is to keep using Internal > Dns service of cloudstack when network provider is some other vendor. > A sample network offering will be like below one:- > Service Provider > DHCP NuageVsp > DNS VirtualRouter/VpcVirtualRouter > UserData VirtualRouter/VpcVirtualRouter > Virtual Networking NuageVsp > SourceNat NuageVsp > StaticNat NuageVsp > NetworkAcl/Firewall NuageVsp > Testrun:- > Verify InternalDns on Isolated Network ... === TestName: > test_01_Isolated_Network_with_zone | Status : SUCCESS === > ok > Verify InternalDns on Isolated Network with ping by hostname ... === > TestName: test_02_Isolated_Network | Status : SUCCESS === > ok > Verify update NetworkDomain for InternalDns on Isolated Network ... === > TestName: test_03_Update_Network_with_Domain | Status : SUCCESS === > ok > Verify update NetworkDomain for InternalDns on Isolated Network with ping VM > ... === TestName: test_04_Update_Network_with_Domain | Status : SUCCESS === > ok > Verify InternalDns on VPC Network ... === TestName: > test_05_VPC_Network_With_InternalDns | Status : SUCCESS === > ok > Verify InternalDns on VPC Network by ping with hostname ... === TestName: > test_06_VPC_Network_With_InternalDns | Status : SUCCESS === > ok > ---------------------------------------------------------------------- > Ran 6 tests in 5736.562s > OK > cloudstack$ pep8 --max-line-length=150 test_internal_dns.py > cloudstack$ pyflakes test_internal_dns.py > cloudstack$ -- This message was sent by Atlassian JIRA (v6.3.4#6332)