[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510725#comment-15510725
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:
--------------------------------------------

Github user nvazquez commented on the issue:

    https://github.com/apache/cloudstack/pull/871
  
    Hi @sanju1010,
    
    @serg38 and I are working on this PR #1677 which solves vm snapshot 
creation issue. After running `test_vm_snapshots.py` we're getting exception on 
`test_01_test_vm_volume_snapshot` as it was expected before your changes in 
this PR.
    
    We're getting: `'CloudstackAPIException: Execute cmd: createsnapshot 
failed, due to: errorCode: 431, errorText:Volume snapshot is not allowed, 
please detach it from VM with VM Snapshots\n']`
    
    This is consistent with `VolumeApiServiceImpl.allocSnapshot` method, in 
which it is:
    ```
            if (volume.getInstanceId() != null) {
                // Check that Vm to which this volume is attached does not have 
VM Snapshots
                if (_vmSnapshotDao.findByVm(volume.getInstanceId()).size() > 0) 
{
                    throw new InvalidParameterValueException("Volume snapshot 
is not allowed, please detach it from VM with VM Snapshots");
                }
            }
    ```
    
    Do you want us to adapt `test_vm_snapshots.py` in mentioned PR to support 
this or would you like to address it yourself?
    
    Thanks


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8893
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Automation
>    Affects Versions: 4.6.0
>            Reporter: Sanjeev N
>            Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)