[jira] [Commented] (CLOUDSTACK-9503) The router script times out resulting in failure of deployment

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15513590#comment-15513590
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9503:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1678#discussion_r80065874
  
    --- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
    @@ -1660,18 +1661,18 @@ public StopAnswer execute(final StopCommand cmd) {
         @Override
         public ExecutionResult executeInVR(final String routerIP, final String 
script, final String args) {
             // Timeout is 120 seconds by default
    -        return executeInVR(routerIP, script, args, 120);
    +        return executeInVR(routerIP, script, args, 
Duration.standardSeconds(120L));
         }
     
         @Override
    -    public ExecutionResult executeInVR(final String routerIP, final String 
script, final String args, final int timeout) {
    +    public ExecutionResult executeInVR(final String routerIP, final String 
script, final String args, final Duration timeout) {
             Pair<Boolean, String> result;
             String cmdline = "/opt/cloud/bin/router_proxy.sh " + script + " " 
+ routerIP + " " + args;
             // semicolon need to be escape for bash
             cmdline = cmdline.replaceAll(";", "\\\\;");
             try {
                 s_logger.debug("Executing command in VR: " + cmdline);
    -            result = SshHelper.sshExecute(_host.getIp(), 22, _username, 
null, _password.peek(), cmdline, 60000, 60000, timeout * 1000);
    +            result = SshHelper.sshExecute(_host.getIp(), 22, _username, 
null, _password.peek(), cmdline, 60000, 60000, (int)timeout.getMillis());
    --- End diff --
    
    Please consider adding an overridden version of the 
`SshHelper.sshExecute(String, int, String, String, ??, String, int, int, int)` 
method that accepts `Duration` to encapsulate this type conversion.


> The router script times out resulting in failure of deployment
> --------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9503
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9503
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Virtual Router
>    Affects Versions: 4.9.0
>         Environment: KVM, Xen
>            Reporter: Abhinandan Prateek
>            Assignee: Abhinandan Prateek
>             Fix For: 4.9.1.0
>
>
> When starting the virtual router in a shared network in advance zone the 
> scripts on router time out. This happen as there are several sub-commands 
> that are consolidated in a single command. The default timeout of 2 minutes 
> is short.
> 2016-09-09 00:06:25,016 ERROR [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
> (Work-Job-Executor-110:ctx-e8089ec7 job-5135/job-5137 ctx-c3a8da18) 
> (logid:8aedea66) process hasn't exited
> 2016-09-09 00:06:25,016 WARN [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
> (Work-Job-Executor-110:ctx-e8089ec7 job-5135/job-5137 ctx-c3a8da18) 
> (logid:8aedea66) Command: com.cloud.agent.api.Command failed while starting 
> virtual router
> 2016-09-09 00:06:25,016 INFO [c.c.v.VirtualMachineManagerImpl] 
> (Work-Job-Executor-110:ctx-e8089ec7 job-5135/job-5137 ctx-c3a8da18) 
> (logid:8aedea66) The guru did not like the answers so stopping 
> VM[DomainRouter|r-3445-VM]
> —



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)