[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538628#comment-15538628
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:
--------------------------------------------

Github user pdion891 commented on the issue:

    https://github.com/apache/cloudstack/pull/1684
  
    I've re-perform my upgrade test this morning with this PR, I just add to 
change ``dynamic.apichecker.enabled`` value have the authentication working, so 
nothing else have to change.
    
    As @PaulAngus raised, in an upgrade scenario where the management-server is 
build for scratch to perform a cloud upgrade, ``dynamic.apichecker.enabled`` 
will cause issues and headache.
    
    So to me it would make more sense if during and upgrade the value of 
``dynamic.apichecker.enabled`` is automatically set to "true" which is already 
the value of a new deployment, then we should update the release notes so if 
users have customized the ``commands.properties`` file, it's up to them to 
rollback ``dynamic.apichecker.enabled`` to false and make sure they have a copy 
of the commands.properties file. what do you think @PaulAngus ?
    
    Maybe the ideal scenario would be that if the ``commands.properties`` file 
exist, cloudstack during is upgrade phase when it's started would update is 
dynamic apichecker values to those defined in the commands.properties 
    
    Does this should go in this PR or we consider this PR is ok?


> When upgrading, Config.java new configuration are not updated.
> --------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9489
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>            Reporter: Pierre-Luc Dion
>            Assignee: Pierre-Luc Dion
>            Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to