[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636781#comment-15636781
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9539:
--------------------------------------------

Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1727
  
    <b>Trillian test result (tid-294)</b>
    Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
    Total time taken: 37155 seconds
    Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1727-t294-vmware-55u3.zip
    Test completed. 45 look ok, 3 have error(s)
    
    
    Test | Result | Time (s) | Test File
    --- | --- | --- | ---
    test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 277.48 | 
test_privategw_acl.py
    test_01_vpc_site2site_vpn | `Error` | 586.21 | test_vpc_vpn.py
    test_01_redundant_vpc_site2site_vpn | `Error` | 757.53 | test_vpc_vpn.py
    ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 747.09 | 
test_vpc_redundant.py
    test_01_vpc_remote_access_vpn | Success | 171.23 | test_vpc_vpn.py
    test_02_VPC_default_routes | Success | 362.52 | test_vpc_router_nics.py
    test_01_VPC_nics_after_destroy | Success | 805.54 | test_vpc_router_nics.py
    test_05_rvpc_multi_tiers | Success | 742.01 | test_vpc_redundant.py
    test_04_rvpc_network_garbage_collector_nics | Success | 1572.75 | 
test_vpc_redundant.py
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 777.10 | test_vpc_redundant.py
    test_02_redundant_VPC_default_routes | Success | 758.86 | 
test_vpc_redundant.py
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1411.46 | 
test_vpc_redundant.py
    test_09_delete_detached_volume | Success | 30.71 | test_volumes.py
    test_06_download_detached_volume | Success | 65.43 | test_volumes.py
    test_05_detach_volume | Success | 110.25 | test_volumes.py
    test_04_delete_attached_volume | Success | 10.14 | test_volumes.py
    test_03_download_attached_volume | Success | 15.19 | test_volumes.py
    test_02_attach_volume | Success | 53.73 | test_volumes.py
    test_01_create_volume | Success | 517.12 | test_volumes.py
    test_change_service_offering_for_vm_with_snapshots | Success | 652.28 | 
test_vm_snapshots.py
    test_03_delete_vm_snapshots | Success | 275.17 | test_vm_snapshots.py
    test_02_revert_vm_snapshots | Success | 226.96 | test_vm_snapshots.py
    test_01_test_vm_volume_snapshot | Success | 246.28 | test_vm_snapshots.py
    test_01_create_vm_snapshots | Success | 162.30 | test_vm_snapshots.py
    test_deploy_vm_multiple | Success | 298.24 | test_vm_life_cycle.py
    test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
    test_advZoneVirtualRouter | Success | 0.01 | test_vm_life_cycle.py
    test_10_attachAndDetach_iso | Success | 27.30 | test_vm_life_cycle.py
    test_09_expunge_vm | Success | 125.20 | test_vm_life_cycle.py
    test_08_migrate_vm | Success | 85.78 | test_vm_life_cycle.py
    test_07_restore_vm | Success | 0.06 | test_vm_life_cycle.py
    test_06_destroy_vm | Success | 10.10 | test_vm_life_cycle.py
    test_03_reboot_vm | Success | 5.12 | test_vm_life_cycle.py
    test_02_start_vm | Success | 40.24 | test_vm_life_cycle.py
    test_01_stop_vm | Success | 10.10 | test_vm_life_cycle.py
    test_CreateTemplateWithDuplicateName | Success | 316.65 | test_templates.py
    test_08_list_system_templates | Success | 0.02 | test_templates.py
    test_07_list_public_templates | Success | 0.03 | test_templates.py
    test_05_template_permissions | Success | 0.04 | test_templates.py
    test_04_extract_template | Success | 15.21 | test_templates.py
    test_03_delete_template | Success | 5.07 | test_templates.py
    test_02_edit_template | Success | 90.14 | test_templates.py
    test_01_create_template | Success | 196.05 | test_templates.py
    test_10_destroy_cpvm | Success | 266.54 | test_ssvm.py
    test_09_destroy_ssvm | Success | 268.51 | test_ssvm.py
    test_08_reboot_cpvm | Success | 156.26 | test_ssvm.py
    test_07_reboot_ssvm | Success | 158.14 | test_ssvm.py
    test_06_stop_cpvm | Success | 181.51 | test_ssvm.py
    test_05_stop_ssvm | Success | 173.29 | test_ssvm.py
    test_04_cpvm_internals | Success | 1.02 | test_ssvm.py
    test_03_ssvm_internals | Success | 3.18 | test_ssvm.py
    test_02_list_cpvm_vm | Success | 0.08 | test_ssvm.py
    test_01_list_sec_storage_vm | Success | 0.08 | test_ssvm.py
    test_01_snapshot_root_disk | Success | 25.95 | test_snapshots.py
    test_04_change_offering_small | Success | 97.42 | test_service_offerings.py
    test_03_delete_service_offering | Success | 0.02 | test_service_offerings.py
    test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
    test_01_create_service_offering | Success | 0.07 | test_service_offerings.py
    test_02_sys_template_ready | Success | 0.08 | test_secondary_storage.py
    test_01_sys_vm_start | Success | 0.11 | test_secondary_storage.py
    test_09_reboot_router | Success | 176.06 | test_routers.py
    test_08_start_router | Success | 156.01 | test_routers.py
    test_07_stop_router | Success | 20.25 | test_routers.py
    test_06_router_advanced | Success | 0.03 | test_routers.py
    test_05_router_basic | Success | 0.03 | test_routers.py
    test_04_restart_network_wo_cleanup | Success | 5.56 | test_routers.py
    test_03_restart_network_cleanup | Success | 190.96 | test_routers.py
    test_02_router_internal_adv | Success | 0.87 | test_routers.py
    test_01_router_internal_basic | Success | 0.47 | test_routers.py
    test_router_dns_guestipquery | Success | 77.11 | test_router_dns.py
    test_router_dns_externalipquery | Success | 0.03 | test_router_dns.py
    test_router_dhcphosts | Success | 148.24 | test_router_dhcphosts.py
    test_01_updatevolumedetail | Success | 5.08 | test_resource_detail.py
    test_01_reset_vm_on_reboot | Success | 30.23 | test_reset_vm_on_reboot.py
    test_createRegion | Success | 0.04 | test_regions.py
    test_create_pvlan_network | Success | 5.15 | test_pvlan.py
    test_dedicatePublicIpRange | Success | 0.27 | test_public_ip_range.py
    test_04_rvpc_privategw_static_routes | Success | 1157.71 | 
test_privategw_acl.py
    test_02_vpc_privategw_static_routes | Success | 710.94 | 
test_privategw_acl.py
    test_01_vpc_privategw_acl | Success | 233.08 | test_privategw_acl.py
    test_01_primary_storage_nfs | Success | 36.40 | test_primary_storage.py
    test_createPortablePublicIPRange | Success | 15.12 | 
test_portable_publicip.py
    test_createPortablePublicIPAcquire | Success | 15.32 | 
test_portable_publicip.py
    test_isolate_network_password_server | Success | 95.12 | 
test_password_server.py
    test_UpdateStorageOverProvisioningFactor | Success | 0.09 | 
test_over_provisioning.py
    test_oobm_zchange_password | Success | 20.54 | test_outofbandmanagement.py
    test_oobm_multiple_mgmt_server_ownership | Success | 16.48 | 
test_outofbandmanagement.py
    test_oobm_issue_power_status | Success | 10.54 | test_outofbandmanagement.py
    test_oobm_issue_power_soft | Success | 15.51 | test_outofbandmanagement.py
    test_oobm_issue_power_reset | Success | 15.51 | test_outofbandmanagement.py
    test_oobm_issue_power_on | Success | 15.52 | test_outofbandmanagement.py
    test_oobm_issue_power_off | Success | 15.51 | test_outofbandmanagement.py
    test_oobm_issue_power_cycle | Success | 16.02 | test_outofbandmanagement.py
    test_oobm_enabledisable_across_clusterzones | Success | 56.99 | 
test_outofbandmanagement.py
    test_oobm_enable_feature_valid | Success | 5.12 | 
test_outofbandmanagement.py
    test_oobm_enable_feature_invalid | Success | 0.07 | 
test_outofbandmanagement.py
    test_oobm_disable_feature_valid | Success | 5.12 | 
test_outofbandmanagement.py
    test_oobm_disable_feature_invalid | Success | 0.07 | 
test_outofbandmanagement.py
    test_oobm_configure_invalid_driver | Success | 0.06 | 
test_outofbandmanagement.py
    test_oobm_configure_default_driver | Success | 0.06 | 
test_outofbandmanagement.py
    test_oobm_background_powerstate_sync | Success | 29.37 | 
test_outofbandmanagement.py
    test_extendPhysicalNetworkVlan | Success | 15.22 | 
test_non_contigiousvlan.py
    test_01_nic | Success | 800.91 | test_nic.py
    test_releaseIP | Success | 307.87 | test_network.py
    test_reboot_router | Success | 669.54 | test_network.py
    test_public_ip_user_account | Success | 10.21 | test_network.py
    test_public_ip_admin_account | Success | 40.20 | test_network.py
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 
76.44 | test_network.py
    test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.31 | 
test_network.py
    test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.74 
| test_network.py
    test_delete_account | Success | 262.58 | test_network.py
    test_02_port_fwd_on_non_src_nat | Success | 55.57 | test_network.py
    test_01_port_fwd_on_src_nat | Success | 111.62 | test_network.py
    test_nic_secondaryip_add_remove | Success | 278.13 | 
test_multipleips_per_nic.py
    login_test_saml_user | Success | 21.41 | test_login.py
    test_assign_and_removal_lb | Success | 148.28 | test_loadbalance.py
    test_02_create_lb_rule_non_nat | Success | 207.03 | test_loadbalance.py
    test_01_create_lb_rule_src_nat | Success | 207.74 | test_loadbalance.py
    test_03_list_snapshots | Success | 0.05 | test_list_ids_parameter.py
    test_02_list_templates | Success | 0.03 | test_list_ids_parameter.py
    test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
    test_07_list_default_iso | Success | 0.04 | test_iso.py
    test_05_iso_permissions | Success | 0.05 | test_iso.py
    test_04_extract_Iso | Success | 5.12 | test_iso.py
    test_03_delete_iso | Success | 95.10 | test_iso.py
    test_02_edit_iso | Success | 0.12 | test_iso.py
    test_01_create_iso | Success | 21.33 | test_iso.py
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 634.32 
| test_internal_lb.py
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 413.12 | 
test_internal_lb.py
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 1067.19 | 
test_internal_lb.py
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 820.34 | 
test_internal_lb.py
    test_dedicateGuestVlanRange | Success | 10.19 | test_guest_vlan_range.py
    test_UpdateConfigParamWithScope | Success | 0.09 | test_global_settings.py
    test_rolepermission_lifecycle_update | Success | 6.36 | test_dynamicroles.py
    test_rolepermission_lifecycle_list | Success | 6.21 | test_dynamicroles.py
    test_rolepermission_lifecycle_delete | Success | 6.15 | test_dynamicroles.py
    test_rolepermission_lifecycle_create | Success | 6.16 | test_dynamicroles.py
    test_rolepermission_lifecycle_concurrent_updates | Success | 6.24 | 
test_dynamicroles.py
    test_role_lifecycle_update_role_inuse | Success | 6.17 | 
test_dynamicroles.py
    test_role_lifecycle_update | Success | 11.29 | test_dynamicroles.py
    test_role_lifecycle_list | Success | 6.16 | test_dynamicroles.py
    test_role_lifecycle_delete | Success | 11.19 | test_dynamicroles.py
    test_role_lifecycle_create | Success | 6.17 | test_dynamicroles.py
    test_role_inuse_deletion | Success | 6.33 | test_dynamicroles.py
    test_role_account_acls_multiple_mgmt_servers | Success | 7.54 | 
test_dynamicroles.py
    test_role_account_acls | Success | 7.63 | test_dynamicroles.py
    test_default_role_deletion | Success | 6.28 | test_dynamicroles.py
    test_04_create_fat_type_disk_offering | Success | 0.04 | 
test_disk_offerings.py
    test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
    test_02_edit_disk_offering | Success | 0.03 | test_disk_offerings.py
    test_02_create_sparse_type_disk_offering | Success | 0.04 | 
test_disk_offerings.py
    test_01_create_disk_offering | Success | 0.07 | test_disk_offerings.py
    test_deployvm_userdispersing | Success | 55.52 | 
test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userconcentrated | Success | 105.77 | 
test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_firstfit | Success | 377.04 | 
test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userdata_post | Success | 30.36 | 
test_deploy_vm_with_userdata.py
    test_deployvm_userdata | Success | 156.06 | test_deploy_vm_with_userdata.py
    test_02_deploy_vm_root_resize | Success | 6.13 | 
test_deploy_vm_root_resize.py
    test_01_deploy_vm_root_resize | Success | 6.13 | 
test_deploy_vm_root_resize.py
    test_00_deploy_vm_root_resize | Success | 6.23 | 
test_deploy_vm_root_resize.py
    test_deploy_vm_from_iso | Success | 242.53 | test_deploy_vm_iso.py
    test_DeployVmAntiAffinityGroup | Success | 276.60 | test_affinity_groups.py
    test_08_resize_volume | Skipped | 5.07 | test_volumes.py
    test_07_resize_fail | Skipped | 15.23 | test_volumes.py
    test_06_copy_template | Skipped | 0.00 | test_templates.py
    test_static_role_account_acls | Skipped | 0.01 | test_staticroles.py
    test_01_scale_vm | Skipped | 66.30 | test_scale_vm.py
    test_01_primary_storage_iscsi | Skipped | 0.02 | test_primary_storage.py
    test_06_copy_iso | Skipped | 0.00 | test_iso.py
    test_deploy_vgpu_enabled_vm | Skipped | 0.00 | 
test_deploy_vgpu_enabled_vm.py



> Support changing Service offering for instance with VM Snapshots
> ----------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9539
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9539
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>
> h3. Actual behaviour
> CloudStack doesn't support changing service offering for vm instances which 
> have vm snapshots, they should be removed before changing service offering.
> h3. Goal
> Extend actual behaviour by supporting changing service offering for vms which 
> have vm snapshots. In that case, previously taken snapshots (if reverted) 
> should use previous service offering, future snapshots should use the newest.
> h3. Proposed solution:
> 1. Adding {{service_offering_id}} column on {{vm_snapshots}} table: This way 
> snapshot can be reverted to original state even though service offering can 
> be changed for vm instance.
> NOTE: Existing vm snapshots are populated on update script by {{UPDATE 
> vm_snapshots s JOIN vm_instance v ON v.id = s.vm_id SET s.service_offering_id 
> = v.service_offering_id;}}
> 2. New vm snapshots will use instance vm service offering id as 
> {{service_offering_id}}
> 3. Revert to vm snapshots should use vm snapshot's {{service_offering_id}} 
> value.
> h3. Example use case:
> - Deploy vm using service offering A
> - Take vm snapshot -> snap1 (service offering A)
> - Stop vm
> - Change vm service offering to B
> - Revert to VM snapshot snap 1
> - Start vm
> It is expected that vm has service offering A after last step



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to