[ https://issues.apache.org/jira/browse/CLOUDSTACK-9402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692542#comment-15692542 ]
ASF GitHub Bot commented on CLOUDSTACK-9402: -------------------------------------------- Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1580#discussion_r89447356 --- Diff: tools/marvin/marvin/lib/base.py --- @@ -3377,6 +3377,40 @@ def list(cls, apiclient, **kwargs): cmd.listall = True return(apiclient.listPortableIpRanges(cmd)) + +class NuageUnderlayPublicIpRange: --- End diff -- I would avoid having non-core components/base resource classes in base.py/marvin. Instead such a class can be moved into a utility module at test/integration/plugins/nuagevsp/ > Nuage VSP Plugin : Support for underlay features (Source & Static NAT to > underlay) including Marvin test coverage on master > --------------------------------------------------------------------------------------------------------------------------- > > Key: CLOUDSTACK-9402 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9402 > Project: CloudStack > Issue Type: Task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation, Network Controller > Affects Versions: 4.10.0.0 > Reporter: Mani Prashanth Varma Manthena > Assignee: Nick Livens > > Support for underlay features (Source & Static NAT to underlay) with Nuage > VSP SDN Plugin including Marvin test coverage for corresponding Source & > Static NAT features on master. Moreover, our Marvin tests are written in such > a way that they can validate our supported feature set with both Nuage VSP > SDN platform's overlay and underlay infra. > PR contents: > 1) Support for Source NAT to underlay feature on master with Nuage VSP SDN > Plugin. > 2) Support for Static NAT to underlay feature on master with Nuage VSP SDN > Plugin. > 3) Marvin test coverage for Source & Static NAT to underlay on master with > Nuage VSP SDN Plugin. > 4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory). > 5) PEP8 & PyFlakes compliance with our Marvin test code. > Our Marvin test code PEP8 & PyFlakes compliance: > CloudStack$ > CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py > CloudStack$ > CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py > CloudStack$ > Validations: > 1) Underlay infra (Source & Static NAT to underlay) > Marvin test run: > nosetests --with-marvin --marvin-config=nuage.cfg > plugins/nuagevsp/test_nuage_source_nat.py > Test results: > Test Nuage VSP Isolated networks with different combinations of Source NAT > service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks > | Status : SUCCESS === > ok > Test Nuage VSP VPC networks with different combinations of Source NAT service > providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : > SUCCESS === > ok > Test Nuage VSP Source NAT functionality for Isolated network by performing > (wget) traffic tests to the ... === TestName: > test_03_nuage_SourceNAT_isolated_network_traffic | Status : SUCCESS === > ok > Test Nuage VSP Source NAT functionality for VPC network by performing (wget) > traffic tests to the Internet ... === TestName: > test_04_nuage_SourceNAT_vpc_network_traffic | Status : SUCCESS === > ok > Test Nuage VSP Source NAT functionality with different Egress > Firewall/Network ACL rules by performing (wget) ... === TestName: > test_05_nuage_SourceNAT_acl_rules_traffic | Status : SUCCESS === > ok > Test Nuage VSP Source NAT functionality with VM NIC operations by performing > (wget) traffic tests to the ... === TestName: > test_06_nuage_SourceNAT_vm_nic_operations_traffic | Status : SUCCESS === > ok > Test Nuage VSP Source NAT functionality with VM migration by performing > (wget) traffic tests to the Internet ... === TestName: > test_07_nuage_SourceNAT_vm_migration_traffic | Status : SUCCESS === > ok > Test Nuage VSP Source NAT functionality with network restarts by performing > (wget) traffic tests to the ... === TestName: > test_08_nuage_SourceNAT_network_restarts_traffic | Status : SUCCESS === > ok > ---------------------------------------------------------------------- > Ran 8 tests in 13360.858s > OK > Marvin test run: > nosetests --with-marvin --marvin-config=nuage.cfg > plugins/nuagevsp/test_nuage_static_nat.py > Test results: > Test Nuage VSP Public IP Range creation and deletion ... === TestName: > test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS === > ok > Test Nuage VSP Nuage Underlay (underlay networking) enabled Public IP Range > creation and deletion ... === TestName: > test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS === > ok > Test Nuage VSP Isolated networks with different combinations of Static NAT > service providers ... === TestName: test_03_nuage_StaticNAT_isolated_networks > | Status : SUCCESS === > ok > Test Nuage VSP VPC networks with different combinations of Static NAT service > providers ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : > SUCCESS === > ok > Test Nuage VSP Static NAT functionality for Isolated network by performing > (wget) traffic tests to the ... === TestName: > test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS === > ok > Test Nuage VSP Static NAT functionality for VPC network by performing (wget) > traffic tests to the Internet ... === TestName: > test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS === > ok > Test Nuage VSP Static NAT functionality with different Egress > Firewall/Network ACL rules by performing (wget) ... === TestName: > test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS === > ok > Test Nuage VSP Static NAT functionality with VM NIC operations by performing > (wget) traffic tests to the ... === TestName: > test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS === > ok > Test Nuage VSP Static NAT functionality with VM migration by performing > (wget) traffic tests to the Internet ... === TestName: > test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS === > ok > Test Nuage VSP Static NAT functionality with network restarts by performing > (wget) traffic tests to the ... === TestName: > test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS === > ok > ---------------------------------------------------------------------- > Ran 10 tests in 9472.468s > OK > 2) Overlay Infra (Source & Static NAT to overlay) > Marvin test run: > nosetests --with-marvin --marvin-config=nuage.cfg > plugins/nuagevsp/test_nuage_source_nat.py > Test results: > Test Nuage VSP Isolated networks with different combinations of Source NAT > service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks > | Status : SUCCESS === > ok > Test Nuage VSP VPC networks with different combinations of Source NAT service > providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : > SUCCESS === > ok > Test Nuage VSP Source NAT functionality for Isolated network by performing > (wget) traffic tests to the ... SKIP: Configured Nuage VSP SDN platform > infrastructure does not support underlay networking: skipping test > Test Nuage VSP Source NAT functionality for VPC network by performing (wget) > traffic tests to the Internet ... SKIP: Configured Nuage VSP SDN platform > infrastructure does not support underlay networking: skipping test > Test Nuage VSP Source NAT functionality with different Egress > Firewall/Network ACL rules by performing (wget) ... SKIP: Configured Nuage > VSP SDN platform infrastructure does not support underlay networking: > skipping test > Test Nuage VSP Source NAT functionality with VM NIC operations by performing > (wget) traffic tests to the ... SKIP: Configured Nuage VSP SDN platform > infrastructure does not support underlay networking: skipping test > Test Nuage VSP Source NAT functionality with VM migration by performing > (wget) traffic tests to the Internet ... SKIP: Configured Nuage VSP SDN > platform infrastructure does not support underlay networking: skipping test > Test Nuage VSP Source NAT functionality with network restarts by performing > (wget) traffic tests to the ... SKIP: Configured Nuage VSP SDN platform > infrastructure does not support underlay networking: skipping test > ---------------------------------------------------------------------- > Ran 8 tests in 1213.858s > OK (SKIP=6) > Marvin test run: > nosetests --with-marvin --marvin-config=nuage.cfg > plugins/nuagevsp/test_nuage_static_nat.py > Test results: > Test Nuage VSP Public IP Range creation and deletion ... === TestName: > test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS === > ok > Test Nuage VSP Nuage Underlay (underlay networking) enabled Public IP Range > creation and deletion ... === TestName: > test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS === > ok > Test Nuage VSP Isolated networks with different combinations of Static NAT > service providers ... === TestName: test_03_nuage_StaticNAT_isolated_networks > | Status : SUCCESS === > ok > Test Nuage VSP VPC networks with different combinations of Static NAT service > providers ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : > SUCCESS === > ok > Test Nuage VSP Static NAT functionality for Isolated network by performing > (wget) traffic tests to the ... === TestName: > test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS === > ok > Test Nuage VSP Static NAT functionality for VPC network by performing (wget) > traffic tests to the Internet ... === TestName: > test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS === > ok > Test Nuage VSP Static NAT functionality with different Egress > Firewall/Network ACL rules by performing (wget) ... === TestName: > test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS === > ok > Test Nuage VSP Static NAT functionality with VM NIC operations by performing > (wget) traffic tests to the ... === TestName: > test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS === > ok > Test Nuage VSP Static NAT functionality with VM migration by performing > (wget) traffic tests to the Internet ... === TestName: > test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS === > ok > Test Nuage VSP Static NAT functionality with network restarts by performing > (wget) traffic tests to the ... === TestName: > test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS === > ok > ---------------------------------------------------------------------- > Ran 10 tests in 8972.563s > OK -- This message was sent by Atlassian JIRA (v6.3.4#6332)