[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714297#comment-15714297
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9633:
--------------------------------------------

GitHub user rhtyd opened a pull request:

    https://github.com/apache/cloudstack/pull/1807

    CLOUDSTACK-9633: Revert addition of `vhd` extention to snapshots

    This reverts commit f1fd325c085cd61336ac616ba76e2c1f3f916cd1 and changes
    introduced in commit f46651e6721106941deeb6b5e6bf51d7e9efc61c that changed 
the
    snapshot file name to include a `vhd` extension.
    
    With this change, CloudStack users should not hit upgrade issues.
    
    Reference: 
https://github.com/apache/cloudstack/pull/1600#pullrequestreview-10955963

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack xen-vhd-extension-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1807.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1807
    
----
commit 2f24ebb7773653de9e389ca6637c47530e7eba46
Author: Rohit Yadav <rohit.ya...@shapeblue.com>
Date:   2016-12-02T07:14:16Z

    CLOUDSTACK-9633: Revert addition of `vhd` extention to snapshots
    
    This reverts commit f1fd325c085cd61336ac616ba76e2c1f3f916cd1 and changes
    introduced in commit f46651e6721106941deeb6b5e6bf51d7e9efc61c that changed 
the
    snapshot file name to include a `vhd` extension.
    
    With this change, CloudStack users should not hit upgrade issues.
    
    Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com>

----


> test_snapshot is failing due to incorrect string construction in utils.py
> -------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9633
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: marvin
>    Affects Versions: 4.10.0.0
>         Environment: https://github.com/apache/cloudstack/pull/1800
>            Reporter: Boris Stoyanov
>             Fix For: 4.10.0.0
>
>
> When searching for the snapshot vhd on the nfs storage it adds 
> ([name].vhd.vhd) I've removed the extension for xenserver and it passed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to