[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729072#comment-15729072 ]
ASF GitHub Bot commented on CLOUDSTACK-9633: -------------------------------------------- Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1807 @abhinandanprateek I will check this. I will start with a non-upgraded cloudstack, create snapshots, upgrade cloudstack to have #1600 and then try to delete older snapshots. From the code it looks like it should delete irrespective of weather the snapshot has the `vhd` extension or not (see [here] (https://github.com/apache/cloudstack/blob/master/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java#L1546) ) because it does a wildcard delete of the directory before. Are you sure that delete will break? Can you point out where this might happen? > test_snapshot is failing due to incorrect string construction in utils.py > ------------------------------------------------------------------------- > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin > Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 > Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)