[ https://issues.apache.org/jira/browse/CLOUDSTACK-9699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806036#comment-15806036 ]
ASF GitHub Bot commented on CLOUDSTACK-9699: -------------------------------------------- Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1884#discussion_r95034357 --- Diff: ui/scripts/system.js --- @@ -15581,7 +15592,12 @@ } }); }, - + actionPreFilter: function(args){ + if (g_enablemetricsui) + return ['add', 'viewMetrics']; + else + return ['add']; + }, --- End diff -- Please code duplication comments above. > Metrics: Add a global setting to enable/disable Metrics view > ------------------------------------------------------------ > > Key: CLOUDSTACK-9699 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9699 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: UI > Affects Versions: 4.7.0, 4.8.0, 4.9.0 > Reporter: Rashmi Dixit > Assignee: Rashmi Dixit > Fix For: 4.10.0.0 > > Attachments: enable-metrics-flag.PNG, metrics-disabled.PNG, > metrics-enabled.PNG > > > The Metrics view for each type of entity basically fires APIs and calculates > required values on the client end. For e.g. to display memory usage etc at > the zone level, it will fetch all zones. For each zone it will fetch > pods->cluster->host->VMs > For a very large Cloudstack installation this will have a major impact on the > performance. > Ideally, there should be an API which calculates all this in the backend and > the UI should simply show the values. However, for the time, introduce a > global setting called enable.metrics which will be set to false. This will > cause the metrics button not to be shown on any of the pages. > If the Admin changes this to true, then the button will be visible and > Metrics functionality will work as usual. -- This message was sent by Atlassian JIRA (v6.3.4#6332)