[ https://issues.apache.org/jira/browse/CLOUDSTACK-9752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832219#comment-15832219 ]
rashmidixit commented on CLOUDSTACK-9752: ----------------------------------------- GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1913 CLOUDSTACK-9752: [Vmware] Optimization of volume attachness to vm ## Description This optimization aims to reduce volume attach slowness due to vmdk files search on datastore before creating the volume (search for `.vmdk`, `-flat.vmdk` and `-delta.vmdk` files to delete them if they exist). This search is not necessary when attaching a volume in Allocated state, due to volume files don't exist on datastore. On large datastores, this search can cause volume attachness to be really slow, as we can see in this log lines: ```` 13-mgmt.log:2016-11-02 10:16:33,136 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file 9ce7731fd38b4045afbb7ce9754abbc1.vmdk in [b5ebda046d613e079b5874b169cd848f] 13-mgmt.log:2016-11-02 10:19:42,567 WARN [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Unable to locate VMDK file: 9ce7731fd38b4045afbb7ce9754abbc1.vmdk 13-mgmt.log:2016-11-02 10:19:42,719 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Search file 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk on [b5ebda046d613e079b5874b169cd848f] ⦠13-mgmt.log:2016-11-02 10:19:44,399 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk in [b5ebda046d613e079b5874b169cd848f] 13-mgmt.log:2016-11-02 10:22:07,581 WARN [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Unable to locate VMDK file: 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk 13-mgmt.log:2016-11-02 10:22:07,731 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Search file 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk on [b5ebda046d613e079b5874b169cd848f] 13-mgmt.log:2016-11-02 10:22:09,745 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk in [b5ebda046d613e079b5874b169cd848f] 13-mgmt.log:2016-11-02 10:25:06,362 WARN [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Unable to locate VMDK file: 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk ```` You can merge this pull request into a Git repository by running: $ git pull https://github.com/nvazquez/cloudstack createVolumeOptimization Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1913.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1913 ---- commit 29308f0c53af1550b52bc0cb5a7558482c6da452 Author: nvazquez <nicolas.m.vazq...@gmail.com> Date: 2017-01-20T16:20:37Z CLOUDSTACK-9752: [Vmware] Optimization of volume attachness to vm ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- > [Vmware] Optimization of volume attachness to vm > ------------------------------------------------ > > Key: CLOUDSTACK-9752 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9752 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VMware > Affects Versions: 4.10.0.0 > Reporter: Nicolas Vazquez > Assignee: Nicolas Vazquez > Fix For: 4.10.0.0 > > > This optimization aims to reduce volume attach slowness due to vmdk files > search on datastore before creating the volume (search for {{.vmdk}}, > {{-flat.vmdk}} and {{-delta.vmdk}} files to delete them if they exist). This > search is not necessary when attaching a volume in Allocated state, due to > volume files don't exist on datastore. > On large datastores, this search can cause volume attachness to be really > slow, as we can see in this log lines: > {code} > 13-mgmt.log:2016-11-02 10:16:33,136 INFO [vmware.mo.DatastoreMO] > (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, > job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file > 9ce7731fd38b4045afbb7ce9754abbc1.vmdk in [b5ebda046d613e079b5874b169cd848f] > 13-mgmt.log:2016-11-02 10:19:42,567 WARN > [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e > uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: > CreateObjectCommand) Unable to locate VMDK file: > 9ce7731fd38b4045afbb7ce9754abbc1.vmdk > 13-mgmt.log:2016-11-02 10:19:42,719 INFO [vmware.mo.DatastoreMO] > (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, > job-8675314/job-8675315, cmd: CreateObjectCommand) Search file > 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk on > [b5ebda046d613e079b5874b169cd848f] > … > 13-mgmt.log:2016-11-02 10:19:44,399 INFO [vmware.mo.DatastoreMO] > (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, > job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file > 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk in > [b5ebda046d613e079b5874b169cd848f] > 13-mgmt.log:2016-11-02 10:22:07,581 WARN > [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e > uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: > CreateObjectCommand) Unable to locate VMDK file: > 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk > 13-mgmt.log:2016-11-02 10:22:07,731 INFO [vmware.mo.DatastoreMO] > (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, > job-8675314/job-8675315, cmd: CreateObjectCommand) Search file > 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk on > [b5ebda046d613e079b5874b169cd848f] > 13-mgmt.log:2016-11-02 10:22:09,745 INFO [vmware.mo.DatastoreMO] > (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, > job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file > 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk in > [b5ebda046d613e079b5874b169cd848f] > 13-mgmt.log:2016-11-02 10:25:06,362 WARN > [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e > uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: > CreateObjectCommand) Unable to locate VMDK file: > 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)