[ https://issues.apache.org/jira/browse/CLOUDSTACK-9604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870644#comment-15870644 ]
ASF GitHub Bot commented on CLOUDSTACK-9604: -------------------------------------------- Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1813 <b>Trillian test result (tid-836)</b> Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38546 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1813-t836-vmware-60u2.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Test completed. 47 look ok, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_privategw_static_routes | `Failure` | 839.38 | test_privategw_acl.py test_00_deploy_vm_root_resize | `Error` | 0.89 | test_deploy_vm_root_resize.py test_01_vpc_site2site_vpn | Success | 327.61 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 146.75 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 568.39 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 304.47 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 666.43 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 618.40 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1488.85 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 664.14 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 594.49 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1301.28 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 21.07 | test_volumes.py test_06_download_detached_volume | Success | 55.68 | test_volumes.py test_05_detach_volume | Success | 100.30 | test_volumes.py test_04_delete_attached_volume | Success | 10.34 | test_volumes.py test_03_download_attached_volume | Success | 15.32 | test_volumes.py test_02_attach_volume | Success | 54.24 | test_volumes.py test_01_create_volume | Success | 435.99 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.23 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 219.23 | test_vm_snapshots.py test_01_test_vm_volume_snapshot | Success | 423.39 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 161.79 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 202.98 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.84 | test_vm_life_cycle.py test_09_expunge_vm | Success | 185.35 | test_vm_life_cycle.py test_08_migrate_vm | Success | 91.53 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py test_06_destroy_vm | Success | 5.14 | test_vm_life_cycle.py test_03_reboot_vm | Success | 5.15 | test_vm_life_cycle.py test_02_start_vm | Success | 20.23 | test_vm_life_cycle.py test_01_stop_vm | Success | 5.12 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 241.83 | test_templates.py test_08_list_system_templates | Success | 0.04 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 15.24 | test_templates.py test_03_delete_template | Success | 5.11 | test_templates.py test_02_edit_template | Success | 90.14 | test_templates.py test_01_create_template | Success | 136.19 | test_templates.py test_10_destroy_cpvm | Success | 236.93 | test_ssvm.py test_09_destroy_ssvm | Success | 238.99 | test_ssvm.py test_08_reboot_cpvm | Success | 246.76 | test_ssvm.py test_07_reboot_ssvm | Success | 369.26 | test_ssvm.py test_06_stop_cpvm | Success | 176.89 | test_ssvm.py test_05_stop_ssvm | Success | 173.74 | test_ssvm.py test_04_cpvm_internals | Success | 1.18 | test_ssvm.py test_03_ssvm_internals | Success | 3.84 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.16 | test_ssvm.py test_01_snapshot_root_disk | Success | 26.25 | test_snapshots.py test_04_change_offering_small | Success | 116.86 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.13 | test_service_offerings.py test_01_create_service_offering | Success | 0.11 | test_service_offerings.py test_02_sys_template_ready | Success | 0.16 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.21 | test_secondary_storage.py test_09_reboot_router | Success | 120.89 | test_routers.py test_08_start_router | Success | 105.80 | test_routers.py test_07_stop_router | Success | 25.25 | test_routers.py test_06_router_advanced | Success | 0.06 | test_routers.py test_05_router_basic | Success | 0.04 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.65 | test_routers.py test_03_restart_network_cleanup | Success | 176.40 | test_routers.py test_02_router_internal_adv | Success | 1.09 | test_routers.py test_01_router_internal_basic | Success | 0.58 | test_routers.py test_router_dns_guestipquery | Success | 76.71 | test_router_dns.py test_router_dns_externalipquery | Success | 0.08 | test_router_dns.py test_router_dhcphosts | Success | 131.56 | test_router_dhcphosts.py test_router_dhcp_opts | Success | 21.66 | test_router_dhcphosts.py test_01_updatevolumedetail | Success | 0.08 | test_resource_detail.py test_01_reset_vm_on_reboot | Success | 50.48 | test_reset_vm_on_reboot.py test_createRegion | Success | 0.04 | test_regions.py test_create_pvlan_network | Success | 5.24 | test_pvlan.py test_dedicatePublicIpRange | Success | 0.45 | test_public_ip_range.py test_03_vpc_privategw_restart_vpc_cleanup | Success | 958.55 | test_privategw_acl.py test_02_vpc_privategw_static_routes | Success | 601.98 | test_privategw_acl.py test_01_vpc_privategw_acl | Success | 182.97 | test_privategw_acl.py test_01_primary_storage_nfs | Success | 36.07 | test_primary_storage.py test_createPortablePublicIPRange | Success | 15.22 | test_portable_publicip.py test_createPortablePublicIPAcquire | Success | 15.45 | test_portable_publicip.py test_isolate_network_password_server | Success | 92.17 | test_password_server.py test_UpdateStorageOverProvisioningFactor | Success | 0.14 | test_over_provisioning.py test_oobm_zchange_password | Success | 30.76 | test_outofbandmanagement.py test_oobm_multiple_mgmt_server_ownership | Success | 16.50 | test_outofbandmanagement.py test_oobm_issue_power_status | Success | 10.29 | test_outofbandmanagement.py test_oobm_issue_power_soft | Success | 15.35 | test_outofbandmanagement.py test_oobm_issue_power_reset | Success | 15.41 | test_outofbandmanagement.py test_oobm_issue_power_on | Success | 15.45 | test_outofbandmanagement.py test_oobm_issue_power_off | Success | 15.35 | test_outofbandmanagement.py test_oobm_issue_power_cycle | Success | 15.35 | test_outofbandmanagement.py test_oobm_enabledisable_across_clusterzones | Success | 87.68 | test_outofbandmanagement.py test_oobm_enable_feature_valid | Success | 5.17 | test_outofbandmanagement.py test_oobm_enable_feature_invalid | Success | 0.12 | test_outofbandmanagement.py test_oobm_disable_feature_valid | Success | 5.25 | test_outofbandmanagement.py test_oobm_disable_feature_invalid | Success | 0.11 | test_outofbandmanagement.py test_oobm_configure_invalid_driver | Success | 0.11 | test_outofbandmanagement.py test_oobm_configure_default_driver | Success | 0.08 | test_outofbandmanagement.py test_oobm_background_powerstate_sync | Success | 23.43 | test_outofbandmanagement.py test_extendPhysicalNetworkVlan | Success | 15.32 | test_non_contigiousvlan.py test_01_nic | Success | 460.22 | test_nic.py test_releaseIP | Success | 202.97 | test_network.py test_reboot_router | Success | 585.01 | test_network.py test_public_ip_user_account | Success | 10.33 | test_network.py test_public_ip_admin_account | Success | 40.31 | test_network.py test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 76.88 | test_network.py test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.82 | test_network.py test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 125.35 | test_network.py test_delete_account | Success | 227.57 | test_network.py test_02_port_fwd_on_non_src_nat | Success | 55.68 | test_network.py test_01_port_fwd_on_src_nat | Success | 111.90 | test_network.py test_nested_virtualization_vmware | Success | 358.79 | test_nested_virtualization.py test_nic_secondaryip_add_remove | Success | 207.69 | test_multipleips_per_nic.py login_test_saml_user | Success | 19.46 | test_login.py test_assign_and_removal_lb | Success | 148.66 | test_loadbalance.py test_02_create_lb_rule_non_nat | Success | 207.25 | test_loadbalance.py test_01_create_lb_rule_src_nat | Success | 207.94 | test_loadbalance.py test_03_list_snapshots | Success | 0.09 | test_list_ids_parameter.py test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py test_07_list_default_iso | Success | 0.07 | test_iso.py test_05_iso_permissions | Success | 0.08 | test_iso.py test_04_extract_Iso | Success | 5.13 | test_iso.py test_03_delete_iso | Success | 95.21 | test_iso.py test_02_edit_iso | Success | 0.09 | test_iso.py test_01_create_iso | Success | 21.01 | test_iso.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 480.53 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 364.16 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 979.65 | test_internal_lb.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 703.05 | test_internal_lb.py test_dedicateGuestVlanRange | Success | 10.26 | test_guest_vlan_range.py test_UpdateConfigParamWithScope | Success | 0.32 | test_global_settings.py test_rolepermission_lifecycle_update | Success | 6.24 | test_dynamicroles.py test_rolepermission_lifecycle_list | Success | 6.07 | test_dynamicroles.py test_rolepermission_lifecycle_delete | Success | 5.93 | test_dynamicroles.py test_rolepermission_lifecycle_create | Success | 5.93 | test_dynamicroles.py test_rolepermission_lifecycle_concurrent_updates | Success | 6.02 | test_dynamicroles.py test_role_lifecycle_update_role_inuse | Success | 5.93 | test_dynamicroles.py test_role_lifecycle_update | Success | 5.95 | test_dynamicroles.py test_role_lifecycle_list | Success | 5.91 | test_dynamicroles.py test_role_lifecycle_delete | Success | 10.96 | test_dynamicroles.py test_role_lifecycle_create | Success | 5.97 | test_dynamicroles.py test_role_inuse_deletion | Success | 6.26 | test_dynamicroles.py test_role_account_acls_multiple_mgmt_servers | Success | 8.19 | test_dynamicroles.py test_role_account_acls | Success | 8.36 | test_dynamicroles.py test_default_role_deletion | Success | 6.01 | test_dynamicroles.py test_04_create_fat_type_disk_offering | Success | 0.08 | test_disk_offerings.py test_03_delete_disk_offering | Success | 0.06 | test_disk_offerings.py test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py test_02_create_sparse_type_disk_offering | Success | 0.08 | test_disk_offerings.py test_01_create_disk_offering | Success | 0.12 | test_disk_offerings.py test_deployvm_userdispersing | Success | 86.20 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userconcentrated | Success | 45.78 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_firstfit | Success | 141.24 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userdata_post | Success | 45.66 | test_deploy_vm_with_userdata.py test_deployvm_userdata | Success | 146.77 | test_deploy_vm_with_userdata.py test_02_deploy_vm_root_resize | Success | 6.02 | test_deploy_vm_root_resize.py test_01_deploy_vm_root_resize | Success | 6.00 | test_deploy_vm_root_resize.py test_deploy_vm_from_iso | Success | 208.09 | test_deploy_vm_iso.py test_3d_gpu_support | Success | 345.20 | test_deploy_vgpu_enabled_vm.py test_DeployVmAntiAffinityGroup | Success | 176.85 | test_affinity_groups.py test_08_resize_volume | Skipped | 5.11 | test_volumes.py test_07_resize_fail | Skipped | 10.30 | test_volumes.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.03 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.03 | test_ssvm.py test_01_scale_vm | Skipped | 66.37 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_deploy_vgpu_enabled_vm | Skipped | 1.17 | test_deploy_vgpu_enabled_vm.py > Root disk resize support for VMware and XenServer > ------------------------------------------------- > > Key: CLOUDSTACK-9604 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9604 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Priyank Parihar > Assignee: Priyank Parihar > Attachments: 1.png, 2.png, 3.png > > > Currently the root size of an instance is locked to that of the template. > This creates unnecessary template duplicates, prevents the creation of a > market place, wastes time and disk space and generally makes work more > complicated. > Real life example - a small VPS provider might want to offer the following > sizes (in GB): > 10,20,40,80,160,240,320,480,620 > That's 9 offerings. > The template selection could look like this, including real disk space used: > Windows 2008 ~10GB > Windows 2008+Plesk ~15GB > Windows 2008+MSSQL ~15GB > Windows 2012 ~10GB > Windows 2012+Plesk ~15GB > Windows 2012+MSSQL ~15GB > CentOS ~1GB > CentOS+CPanel ~3GB > CentOS+Virtualmin ~3GB > CentOS+Zimbra ~3GB > CentOS+Docker ~2GB > Debian ~1GB > Ubuntu LTS ~1GB > In this case the total disk space used by templates will be 828 GB, that's > almost 1 TB. If your storage is expensive and limited SSD this can get > painful! > If the root resize feature is enabled we can reduce this to under 100 GB. > Specifications and Description > Administrators don't want to deploy duplicate OS templates of differing > sizes just to support different storage packages. Instead, the VM deployment > can accept a size for the root disk and adjust the template clone > accordingly. In addition, CloudStack already supports data disk resizing for > existing volumes, we can extend that functionality to resize existing root > disks. > As mentioned, we can leverage the existing design for resizing an existing > volume. The difference with root volumes is that we can't resize via disk > offering, therefore we need to verify that no disk offering was passed, just > a size. The existing enforcements of new size > existing size will still > server their purpose. > For deployment-based resize (ROOT volume size different from template > size), we pass the rootdisksize parameter when the existing code allocates > the root volume. In the process, we validate that the root disk size is > > existing template size, and non-zero. This will persist the root volume as > the desired size regardless of whether or not the VM is started on deploy. > Then hypervisor specific code needs to be made to pay attention to the > VolumeObjectTO's size attribute and use that when doing the work of cloning > from template, rather than inheriting the template's size. This can be > implemented one hypervisor at a time, and as such there needs to be a check > in UserVmManagerImpl to fail unsupported hypervisors with > InvalidParameterValueException when the rootdisksize is passed. > > Hypervisor specific changes > XenServer > Resize ROOT volume is only supported for stopped VMs > Newly created ROOT volume will be resized after clone from template > VMware > Resize ROOT volume is only supported for stopped VMs. > New size should be large then the previous size. > Newly created ROOT volume will be resized after clone from template iff > There is no root disk chaining.(means use Full clone) > And Root Disk controller setting is not IDE. > Previously created Root Volume could be resized iif > There is no root disk chaining. > And Root Disk controller setting is not IDE. > Web Services APIs > resizeVolume API call will not change, but it will accept volume UUIDs of > root volumes in id parameter for resizing. > deployVirtualMachine API call will allow new rootdisksize parameter to be > passed. This parameter will be used as the disk size (in GB) when cloning > from template. > UI > 1) (refer attached image 1) shows UI that resize volume option is added for > ROOT disks. > 2) (refer attached image 2) when user calls the resize volume on ROOT volume. > Here only size option is shown. For DATADISK disk offerings are shown. > 3) (refer attached image 3) when user deploys VM. New option for Root disk > size is added. -- This message was sent by Atlassian JIRA (v6.3.15#6346)