[
https://issues.apache.org/jira/browse/CLOUDSTACK-9723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880032#comment-15880032
]
ASF GitHub Bot commented on CLOUDSTACK-9723:
--------------------------------------------
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r102651320
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long
networkId, final long accountId, f
}
@Override
- public String getNextAvailableMacAddress(final long networkConfigId) {
+ public String getNextAvailableMacAddress(final long networkConfigId,
Integer zoneMacIdentifier) {
final SequenceFetcher fetch = SequenceFetcher.getInstance();
-
long seq = fetch.getNextSequence(Long.class, _tgMacAddress,
networkConfigId);
- seq = seq | _prefix << 40 | _rand.nextInt(Short.MAX_VALUE) << 16 &
0x00000000ffff0000l;
+ if(zoneMacIdentifier!=0){
+ seq = seq | _prefix << 40 | (long)zoneMacIdentifier << 32 |
networkConfigId << 16 & 0x00000000ffff0000l;
+ }
+ else {
+ seq = seq | _prefix << 40 | _rand.nextInt(Short.MAX_VALUE) <<
16 & 0x00000000ffff0000l;
+
+ }
--- End diff --
formatted
> Enable unique mac address across different deployments and networks
> -------------------------------------------------------------------
>
> Key: CLOUDSTACK-9723
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9723
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Jayapal Reddy
> Assignee: Jayapal Reddy
> Fix For: 4.10.0.0
>
>
> Specify the MAC address range for VMs created in ACS
> If there are Multiple CCP environments, There is difficulty in identifying
> VMs based on their MAC addresses since the addresses are duplicated across
> environments.
> Specifying the MAC address range in zone will avoid the conflict.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
