[ https://issues.apache.org/jira/browse/CLOUDSTACK-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886608#comment-15886608 ]
ASF GitHub Bot commented on CLOUDSTACK-9795: -------------------------------------------- Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1973 @dmabry as I posted on the other PR, I only suggested `git cherry-pick` because I thought it would preserve the commit hash. It was a misunderstanding from me. The git hash is generated based on parent commit as well as other bits of information. Therefore, even when using `git cherry-pick` the hash of commits between branches will always be different (unless a hash collision happens). The `git cherry-pick` is quite useful when you have to apply a bunch of changes, but in your case, I do not think you need it. The way you did before was ok. BTW: I think a single commit to introduce these changes is enough ;) > VRs used as VPC Routers have logrotate in cron.daily instead of cron.hourly > --------------------------------------------------------------------------- > > Key: CLOUDSTACK-9795 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9795 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VPC > Affects Versions: 4.8.0, 4.9.0, 4.8.1.1, 4.9.0.1 > Environment: The VR when deploy as a stand alone router has logrotate > moved from cron.daily to cron.hourly, but when used as a VPC router > (vpcrouter) the logrotate file is left in cron.daily. > Reporter: David Mabry > Priority: Minor > Labels: easyfix > Fix For: 4.10 > > > The VR when deploy as a stand alone router has logrotate moved from > cron.daily to cron.hourly, but when used as a VPC router (vpcrouter) the > logrotate file is left in cron.daily. > This causes anyone using the VR as a VPC to have issues with /var/log filling > up and causing the VR to fail ungracefully. This prevents VMs from spinning > up in the VPC, adding new acls and creating new LB rules. > The fix is to move the logrotate from cron.daily to cron.hourly and configure > cloud.log to rotate and compress at 20MB. I will submit a PR against master > that will move logrotate. It is a minor change to cloud-early on the VRs. -- This message was sent by Atlassian JIRA (v6.3.15#6346)