[ https://issues.apache.org/jira/browse/CLOUDSTACK-8826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886852#comment-15886852 ]
ASF subversion and git services commented on CLOUDSTACK-8826: ------------------------------------------------------------- Commit d9bd01266ffb23f591283c058beff6e65d1cc4aa in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d9bd012 ] Merge pull request #1829 from syed/hvm-volume-attach-restart-fix CLOUDSTACK-9363: Fix HVM VM restart bug in XenServerHere is the longer description of the problem: By default XenServer limits HVM guests to only 4 disks. Two of those are reserved for the ROOT disk (deviceId=0) and CD ROM (device ID=3) which means that we can only attach 2 data disks. This limit however is removed when Xentools is installed on the guest. The information that a guest has Xentools installed and can handle more than 4 disks is stored in the VM metadata on XenServer. When a VM is shut down, Cloudstack removes the VM and all the metadata associated with the VM from XenServer. Now, when you start the VM again, even if it has Xentools installed, it will default to only 4 attachable disks. Now this problem manifests itself when you have a HVM VM and you stop and start it with more than 2 data disks attached. The VM fails to start and the only way to start the VM is to detach the extra disks and then reattach them after the VM start. In this fix, I am removing the check which is done before creating a `VBD` which enforces this limit. This will not affect current workflow and will fix the HVM issue. @koushik-das this is related to the "autodetect" feature that you introduced a while back (https://issues.apache.org/jira/browse/CLOUDSTACK-8826). I would love your review on this fix. * pr/1829: Fix HVM VM restart bug in XenServer Signed-off-by: Rajani Karuturi <rajani.karut...@accelerite.com> > XenServer - Use device id passed as part of attach volume API properly > ---------------------------------------------------------------------- > > Key: CLOUDSTACK-8826 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8826 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: XenServer > Affects Versions: 4.6.0 > Reporter: Koushik Das > Assignee: Koushik Das > Fix For: 4.6.0 > > > Random failures were seen in XS attach/detach volume test scenarios (many > attach/detach were performed on the same VM over a span of 24 hrs). > The failures happened as the device id for attaching volume wasn't available > in HV. Some detached volume didn't got cleaned up properly and so the device > id wasn't released. > The fix would be clean up stale volumes before attaching new ones so the > device slots are released. Also using the device id should be best effort and > if that particular id is not available in XS, it should fallback on using an > id that is available and automatically assigned. -- This message was sent by Atlassian JIRA (v6.3.15#6346)