[ https://issues.apache.org/jira/browse/CLOUDSTACK-9104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887784#comment-15887784 ]
ASF GitHub Bot commented on CLOUDSTACK-9104: -------------------------------------------- Github user priyankparihar commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r103427150 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) { return new String[] {datastoreDiskPath}; } - // Pair<internal CS name, vCenter display name> - private Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) { - String vmInternalCSName = vmSpec.getName(); - String vmNameOnVcenter = vmSpec.getName(); - if (_instanceNameFlag && vmSpec.getHostName() != null) { - vmNameOnVcenter = vmSpec.getHostName(); + /** + * This method generates VM name for Vcenter and Cloudstack( when Hypervisor is VMware). + * It generates VM name according to _instanceNameFlag setting. + * + * @param VirtualMachineTO + * vmSpec + * @return Pair<internal CS name, vCenter display name>. A pair which contain 'internal CS name' and + * 'vCenter display name'(vCenter knows VM by this name). + **/ + protected Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) { + --- End diff -- >Why is the method attribute changed from private to protected? Otherwise Unit testing will be difficult. >If vmspec is null, this method should throw an exception, to avoid a situation where empty vmnames are returned. In CS vmspec can not be null. But still code will be modified according your suggestion. > VM naming convention in case vmware is used > ------------------------------------------- > > Key: CLOUDSTACK-9104 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9104 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Priyank Parihar > Assignee: Priyank Parihar > > ISSUE > ====== > VM naming convention in case vmware is used. > Description > ========== > User with different account cannot create VMs with the same name, which was > possible earlier (I am not sure in which CCP version). That time naming > convention used was like this “I-<user-id>-<Display-Name>” > Currently if vm.instancename.flag is set to true the VM name will be exactly > as display name given. -- This message was sent by Atlassian JIRA (v6.3.15#6346)