[
https://issues.apache.org/jira/browse/CLOUDSTACK-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941998#comment-15941998
]
ASF GitHub Bot commented on CLOUDSTACK-9843:
--------------------------------------------
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/2015
@sudhansu7 Thanks for the fix. We need to update the unit test as well.
Please check:
```
diff --git
a/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java
b/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java
index c7282c426..b9b7213c8 100644
--- a/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java
+++ b/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java
@@ -126,6 +126,5 @@ public class SshHelperTest {
Mockito.verify(conn).openSession();
PowerMockito.verifyStatic();
- Thread.sleep(Mockito.anyLong());
}
}
```
Test `openConnectionSessionTest` passes again for me after above change.
> Performance improvement of deployVirtualMachine, createFirewallRule,
> createPortForwardingRule
> ---------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9843
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9843
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Affects Versions: 4.10.0.0
> Reporter: Sudhansu Sahu
> Assignee: Sudhansu Sahu
>
> A delay of 1 sec has been introduced in SSHHelper Class. This is a fail safe
> code. Removing this will improves the performance of deployVm by 4 sec,
> createFirewallRule by 1 sec and createPortForwardingRule by 1 sec.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
