[ https://issues.apache.org/jira/browse/CLOUDSTACK-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944574#comment-15944574 ]
ASF subversion and git services commented on CLOUDSTACK-9827: ------------------------------------------------------------- Commit 525c45c1e5f2fbf46e9379e05754ad15f2ff811d in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=525c45c ] Merge pull request #1994 from nvazquez/CLOUDSTACK-9827 CLOUDSTACK-9827: Storage tags stored in multiple placesIssue description: https://issues.apache.org/jira/browse/CLOUDSTACK-9827 ### Fixes - Create Primary Storage: Persist tags into `storage_pool_tags` instead of `storage_pool_details` - List Storage Tags: Queries `storage_pool_tags` table instead of `storage_tag_view` - Find Storage Pools by Tags using proper DAO - Remove storage tags after deleting Primary Storage - Remove unused `StorageTagDao`, `StorageTagDaoImpl`, `StorageTagVO` and `storage_tag_view` * pr/1994: CLOUDSTACK-9827: Storage tags stored in multiple places Signed-off-by: Rajani Karuturi <rajani.karut...@accelerite.com> > Storage tags stored in multiple places > -------------------------------------- > > Key: CLOUDSTACK-9827 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9827 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server > Affects Versions: 4.10.0.0 > Environment: N/A > Reporter: Mike Tutkowski > Assignee: Nicolas Vazquez > Priority: Blocker > Fix For: 4.10.0.0 > > > I marked this as a Blocker because it concerns me that we are not handling > storage tags correctly in 4.10 and, as such, VM storage might get placed in > locations that users don't want. > From e-mails I sent to dev@ (most recent to oldest): > If I add a new primary storage and give it a storage tag, the tag ends up in > storage_pool_details. > If I edit an existing storage pool’s storage tags, it places them in > storage_pool_tags. > ********** > I believe I have found another bug (one that we should either fix or examine > in detail before releasing 4.10). > It looks like we have a new table: cloud.storage_pool_tags. > The addition of this table seems to have broken the listStorageTags API > command. When this command runs, it doesn’t pick up any storage tags for me > (and I know I have one storage tag). > This data used to be stored in the cloud.storage_pool_details table. It’s > good to put it in its own table, but will our upgrade process move the > existing tags from storage_pool_details to storage_pool_tags? -- This message was sent by Atlassian JIRA (v6.3.15#6346)