[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945286#comment-15945286
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9854:
--------------------------------------------

GitHub user nvazquez opened a pull request:

    https://github.com/apache/cloudstack/pull/2021

    CLOUDSTACK-9854: Fix test_primary_storage test failure due to live migration

    Fix for test_primary_storage integration tests on simulator.
    
    When finding storage pool migration options for volume on running vm, API 
returns None as hypervisor doesn't support live migration.
    
    ````
    2017-03-28 06:07:55,958 - DEBUG - ========Sending GET Cmd : 
findStoragePoolsForMigration=======
    2017-03-28 06:07:55,977 - DEBUG - Response : None
    2017-03-28 06:07:55,983 - CRITICAL - EXCEPTION: 
test_03_migration_options_storage_tags: ['Traceback (most recent call 
last):\n', '  File "/opt/python/2.7.12/lib/python2.7/unittest/case.py", line 
329, in run\n    testMethod()\n', '  File 
"/home/travis/.local/lib/python2.7/site-packages/marvin/lib/decoratorGenerators.py",
 line 30, in test_wrapper\n    return test(self, *args, **kwargs)\n', '  File 
"/home/travis/build/apache/cloudstack/test/integration/smoke/test_primary_storage.py",
 line 547, in test_03_migration_options_storage_tags\n    pools_suitable = 
filter(lambda p : p.suitableformigration, pools_response)\n', "TypeError: 
'NoneType' object is not iterable\n"]
    ````
    
    So we simply stop vm before sending findStoragePoolsForMigration command

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nvazquez/cloudstack CLOUDSTACK-9854

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/2021.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2021
    
----
commit e313dafea46cf281bf09cc66cfcaf6a38d53ca90
Author: nvazquez <nicovazque...@gmail.com>
Date:   2017-03-28T14:35:55Z

    CLOUDSTACK-9854: Fix test_primary_storage test failure due to live migration

----


> Fix test_primary_storage test failure due to live migration
> -----------------------------------------------------------
>
>                 Key: CLOUDSTACK-9854
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9854
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Test
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>
> Fix for test_primary_storage integration tests on simulator.
> When finding storage pool migration options for volume on running vm, API 
> returns None as hypervisor doesn't support live migration.
> {noformat}
> 2017-03-28 06:07:55,958 - DEBUG - ========Sending GET Cmd : 
> findStoragePoolsForMigration=======
> 2017-03-28 06:07:55,977 - DEBUG - Response : None
> 2017-03-28 06:07:55,983 - CRITICAL - EXCEPTION: 
> test_03_migration_options_storage_tags: ['Traceback (most recent call 
> last):\n', '  File "/opt/python/2.7.12/lib/python2.7/unittest/case.py", line 
> 329, in run\n    testMethod()\n', '  File 
> "/home/travis/.local/lib/python2.7/site-packages/marvin/lib/decoratorGenerators.py",
>  line 30, in test_wrapper\n    return test(self, *args, **kwargs)\n', '  File 
> "/home/travis/build/apache/cloudstack/test/integration/smoke/test_primary_storage.py",
>  line 547, in test_03_migration_options_storage_tags\n    pools_suitable = 
> filter(lambda p : p.suitableformigration, pools_response)\n', "TypeError: 
> 'NoneType' object is not iterable\n"]
> {noformat}
> So we simply stop vm before sending findStoragePoolsForMigration command



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to