[ https://issues.apache.org/jira/browse/CLOUDSTACK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214968#comment-16214968 ]
ASF GitHub Bot commented on CLOUDSTACK-9889: -------------------------------------------- nitin-maharana commented on a change in pull request #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain URL: https://github.com/apache/cloudstack/pull/2102#discussion_r146232407 ########## File path: engine/schema/src/com/cloud/network/dao/DomainGuestVlanMapDao.java ########## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package com.cloud.network.dao; + +import com.cloud.utils.db.GenericDao; +import java.util.List; + +public interface DomainGuestVlanMapDao extends GenericDao<DomainGuestVlanMapVO, Long> { + + public List<DomainGuestVlanMapVO> listDomainGuestVlanMapsByDomain(long domainId); Review comment: Here as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Dedicate guest vlan range to a domain > -------------------------------------- > > Key: CLOUDSTACK-9889 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9889 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: subhash yedugundla > > List of scenarios covered > *Dedication of guest Vlan range* > Admin should be allowed dedicate guest vlan ranges to a domain > While dedicating a guest Vlan range > If the range overlaps with any of the existing dedicated range then extend > the existing dedicated range > Otherwise add it as a new dedicated guest Vlan range > If the range doesn’t exist in the system then the request should fail > If any of the vlan in the range is in use by a network that belongs to a > different account of different domain then the request should fail > *Releasing guest Vlan range* > Admin should be allowed to release a dedicated guest vlan range that is > dedicated to a domain back to the system pool > If the range is not dedicated to the domain then the request should fail > Even If one/more of the Vlans belonging to the range is in use by a network > the range should be released back to the system pool > The vlans that are in use should continue to be in use by the network > *Network implementation* > If the network belongs to an account that has a dedicated range of Vlans then > a Vlan from the account's dedicated range should be allocated to the network > If an account uses up all of its dedicated Vlan’s the next network being > created for the account should be assigned a Vlan that belongs to the domain > pool > Otherwise, a Vlan should be allocated from the free pool i.e. Vlan range > belonging to the zone > *Network creation* > If a Vlan id is specified and if this id belongs to a dedicated Vlan range of > a different account/domain then the creation should fail > If a Vlan id is specified and if this id belongs to the system pool but the > network owner has a range of dedicated range of vlans then the creation > should fail > *Domain deletion* > Guest Ip ranges and vlans dedicated to the domain should be released back to > the free pool > *Account deletion* > When an account is deleted, the IP ranges and vlans associated with the > account should be moved to system pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)