[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262349#comment-16262349
 ] 

ASF GitHub Bot commented on CLOUDSTACK-7793:
--------------------------------------------

rhtyd commented on a change in pull request #2312: CLOUDSTACK-7793 Create 
Snaphot with quiesce option set to true fails …
URL: https://github.com/apache/cloudstack/pull/2312#discussion_r152537685
 
 

 ##########
 File path: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
 ##########
 @@ -603,9 +603,9 @@ private boolean orchestrateDeleteVMSnapshot(Long 
vmSnapshotId) {
 
         _accountMgr.checkAccess(caller, null, true, vmSnapshot);
 
-        // check VM snapshot states, only allow to delete vm snapshots in 
created and error state
-        if (VMSnapshot.State.Ready != vmSnapshot.getState() && 
VMSnapshot.State.Expunging != vmSnapshot.getState() && VMSnapshot.State.Error 
!= vmSnapshot.getState()) {
-            throw new InvalidParameterValueException("Can't delete the vm 
snapshotshot " + vmSnapshotId + " due to it is not in Created or Error, or 
Expunging State");
+        // check VM snapshot states, only allow to delete vm snapshots in 
ready, expunging, allocated and error state
+        if (VMSnapshot.State.Ready != vmSnapshot.getState() && 
VMSnapshot.State.Expunging != vmSnapshot.getState() && VMSnapshot.State.Error 
!= vmSnapshot.getState() && VMSnapshot.State.Allocated != 
vmSnapshot.getState()) {
+            throw new InvalidParameterValueException("Can't delete the vm 
snapshotshot " + vmSnapshotId + " due to it is not in Ready, Error, Allocated 
or Expunging State");
 
 Review comment:
   @yvsubhash can you fix the typo in `snapshotshot`, perhaps consider checking 
if `vmSnapshot.getState()` is in in the list of states, instead of comparing 
against each individually. You may further use that `list` of states in the 
thrown exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Snapshots]Create Snaphot with "quiesce" option set to true fails with 
> "InvalidParameterValueException: can't handle quiescevm equal true for volume 
> snapshot"
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-7793
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7793
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Snapshot
>    Affects Versions: 4.5.0
>         Environment: Latest build from 4.5
>            Reporter: Sanjeev N
>            Priority: Critical
>         Attachments: management-server.rar
>
>
> [Snapshots]Create Snaphot with "quiesce" option set to true fails with 
> "InvalidParameterValueException: can't handle quiescevm equal true for volume 
> snapshot"
> Steps to Reproduce:
> ===============
> 1.Bring up CS in advanced zone with vmware cluster
> 2.Deploy guest vm using default cent os template
> 3.Try to create snapshot on root disk with "quiesce" option set to true:
> http://10.147.38.153:8096/client/api?command=createSnapshot&volumeid=998fd155-7d60-4426-a91c-0a2f1d598021&account=test&domainid=1&quiescevm=true
> Expected Result:
> ============
> quiescevm is implemented only for NetApp Plugin with VMWare. If this is not 
> implemented the API should simply ignore the option
> Actual Result:
> ==========
> API  didn't ignore this option. Instead it failed with following exception:
> 2014-10-27 18:10:59,861 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (ApiServer-7:ctx-2f20ab36 ctx-a7e2aa42) submit async job-147, details: 
> AsyncJobVO {id:147, userId: 1, accountId: 1, instanceType: Snapshot, 
> instanceId: 13, cmd: 
> org.apache.cloudstack.api.command.user.snapshot.CreateSnapshotCmd, cmdInfo: 
> {"id":"13","ctxDetails":"{\"com.cloud.storage.Snapshot\":\"7668446f-667a-4398-a623-23d87067a9f4\",\"com.cloud.storage.Volume\":\"998fd155-7d60-4426-a91c-0a2f1d598021\",\"com.cloud.domain.Domain\":1}","cmdEventType":"SNAPSHOT.CREATE","ctxUserId":"1","account":"test","httpmethod":"GET","volumeid":"998fd155-7d60-4426-a91c-0a2f1d598021","domainid":"1","quiescevm":"true","uuid":"7668446f-667a-4398-a623-23d87067a9f4","ctxAccountId":"1","ctxStartEventId":"301"},
>  cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
> null, initMsid: 6637838401571, completeMsid: null, lastUpdated: null, 
> lastPolled: null, created: null}
> 2014-10-27 18:10:59,880 INFO  [o.a.c.f.j.i.AsyncJobMonitor] 
> (API-Job-Executor-44:ctx-15935b7b job-147) Add job-147 into job monitoring
> 2014-10-27 18:10:59,881 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (API-Job-Executor-44:ctx-15935b7b job-147) Executing AsyncJobVO {id:147, 
> userId: 1, accountId: 1, instanceType: Snapshot, instanceId: 13, cmd: 
> org.apache.cloudstack.api.command.user.snapshot.CreateSnapshotCmd, cmdInfo: 
> {"id":"13","ctxDetails":"{\"com.cloud.storage.Snapshot\":\"7668446f-667a-4398-a623-23d87067a9f4\",\"com.cloud.storage.Volume\":\"998fd155-7d60-4426-a91c-0a2f1d598021\",\"com.cloud.domain.Domain\":1}","cmdEventType":"SNAPSHOT.CREATE","ctxUserId":"1","account":"test","httpmethod":"GET","volumeid":"998fd155-7d60-4426-a91c-0a2f1d598021","domainid":"1","quiescevm":"true","uuid":"7668446f-667a-4398-a623-23d87067a9f4","ctxAccountId":"1","ctxStartEventId":"301"},
>  cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
> null, initMsid: 6637838401571, completeMsid: null, lastUpdated: null, 
> lastPolled: null, created: null}
> 2014-10-27 18:10:59,955 INFO  [o.a.c.a.c.u.s.CreateSnapshotCmd] 
> (API-Job-Executor-44:ctx-15935b7b job-147 ctx-9af4a710) VOLSS: 
> createSnapshotCmd starts:1414413659955
> 2014-10-27 18:10:59,978 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (API-Job-Executor-44:ctx-15935b7b job-147 ctx-9af4a710) Sync job-148 
> execution on object VmWorkJobQueue.14
> 2014-10-27 18:11:00,456 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
> (RouterStatusMonitor-1:ctx-f35c279c) Found 2 routers to update status.
> 2014-10-27 18:11:00,458 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
> (RouterStatusMonitor-1:ctx-f35c279c) Found 0 networks to update RvR status.
> 2014-10-27 18:11:00,526 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (AsyncJobMgr-Heartbeat-1:ctx-473efbed) Execute sync-queue item: 
> SyncQueueItemVO {id:52, queueId: 34, contentType: AsyncJob, contentId: 148, 
> lastProcessMsid: null, lastprocessNumber: null, lastProcessTime: null, 
> created: Mon Oct 27 18:10:59 IST 2014}
> 2014-10-27 18:11:00,529 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (AsyncJobMgr-Heartbeat-1:ctx-473efbed) Schedule queued job-148
> 2014-10-27 18:11:00,561 INFO  [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (AsyncJobMgr-Heartbeat-1:ctx-8dfe1318) Begin cleanup expired async-jobs
> 2014-10-27 18:11:00,562 INFO  [o.a.c.f.j.i.AsyncJobMonitor] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148) Add job-148 into job 
> monitoring
> 2014-10-27 18:11:00,563 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148) Executing AsyncJobVO 
> {id:148, userId: 1, accountId: 1, instanceType: null, instanceId: null, cmd: 
> com.cloud.storage.VmWorkTakeVolumeSnapshot, cmdInfo: 
> rO0ABXNyACpjb20uY2xvdWQuc3RvcmFnZS5WbVdvcmtUYWtlVm9sdW1lU25hcHNob3QEvmAbguLVzwIABFoACXF1aWVzY2VWbUwACHBvbGljeUlkdAAQTGphdmEvbGFuZy9Mb25nO0wACnNuYXBzaG90SWRxAH4AAUwACHZvbHVtZUlkcQB-AAF4cgATY29tLmNsb3VkLnZtLlZtV29ya5-ZtlbwJWdrAgAESgAJYWNjb3VudElkSgAGdXNlcklkSgAEdm1JZEwAC2hhbmRsZXJOYW1ldAASTGphdmEvbGFuZy9TdHJpbmc7eHAAAAAAAAAABAAAAAAAAAABAAAAAAAAAA50ABRWb2x1bWVBcGlTZXJ2aWNlSW1wbAFzcgAOamF2YS5sYW5nLkxvbmc7i-SQzI8j3wIAAUoABXZhbHVleHIAEGphdmEubGFuZy5OdW1iZXKGrJUdC5TgiwIAAHhwAAAAAAAAAABzcQB-AAYAAAAAAAAADXNxAH4ABgAAAAAAAAAQ,
>  cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
> null, initMsid: 6637838401571, completeMsid: null, lastUpdated: null, 
> lastPolled: null, created: Mon Oct 27 18:10:59 IST 2014}
> 2014-10-27 18:11:00,564 DEBUG [c.c.v.VmWorkJobDispatcher] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148) Run VM work job: 
> com.cloud.storage.VmWorkTakeVolumeSnapshot for VM 14, job origin: 147
> 2014-10-27 18:11:00,570 DEBUG [c.c.v.VmWorkJobHandlerProxy] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148 ctx-8ffe0ed1) Execute VM 
> work job: 
> com.cloud.storage.VmWorkTakeVolumeSnapshot{"volumeId":16,"policyId":0,"snapshotId":13,"quiesceVm":true,"userId":1,"accountId":4,"vmId":14,"handlerName":"VolumeApiServiceImpl"}
> 2014-10-27 18:11:00,581 INFO  [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (AsyncJobMgr-Heartbeat-1:ctx-8dfe1318) End cleanup expired async-jobs
> 2014-10-27 18:11:00,586 DEBUG [c.c.s.s.SnapshotManagerImpl] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148 ctx-8ffe0ed1) Failed to 
> create snapshot
> com.cloud.exception.InvalidParameterValueException: can't handle quiescevm 
> equal true for volume snapshot
>         at 
> org.apache.cloudstack.storage.snapshot.XenserverSnapshotStrategy.takeSnapshot(XenserverSnapshotStrategy.java:270)
>         at 
> com.cloud.storage.snapshot.SnapshotManagerImpl.takeSnapshot(SnapshotManagerImpl.java:971)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:601)
>         at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
>         at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>         at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
>         at $Proxy180.takeSnapshot(Unknown Source)
>         at 
> org.apache.cloudstack.storage.volume.VolumeServiceImpl.takeSnapshot(VolumeServiceImpl.java:1534)
>         at 
> com.cloud.storage.VolumeApiServiceImpl.orchestrateTakeVolumeSnapshot(VolumeApiServiceImpl.java:1932)
>         at 
> com.cloud.storage.VolumeApiServiceImpl.orchestrateTakeVolumeSnapshot(VolumeApiServiceImpl.java:2691)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:601)
>         at 
> com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
>         at 
> com.cloud.storage.VolumeApiServiceImpl.handleVmWorkJob(VolumeApiServiceImpl.java:2699)
>         at sun.reflect.GeneratedMethodAccessor489.invoke(Unknown Source)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:601)
>         at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
>         at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>         at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
>         at $Proxy184.handleVmWorkJob(Unknown Source)
>         at 
> com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
>         at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:513)
>         at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
>         at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
>         at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:470)
>         at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>         at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:166)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
>         at java.lang.Thread.run(Thread.java:722)
> 2014-10-27 18:11:00,620 DEBUG [o.a.c.s.v.VolumeServiceImpl] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148 ctx-8ffe0ed1) Take 
> snapshot: 16 failed
> com.cloud.utils.exception.CloudRuntimeException: Failed to create snapshot
>         at 
> com.cloud.storage.snapshot.SnapshotManagerImpl.takeSnapshot(SnapshotManagerImpl.java:988)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:601)
>         at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
>         at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>         at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
>         at $Proxy180.takeSnapshot(Unknown Source)
>         at 
> org.apache.cloudstack.storage.volume.VolumeServiceImpl.takeSnapshot(VolumeServiceImpl.java:1534)
>         at 
> com.cloud.storage.VolumeApiServiceImpl.orchestrateTakeVolumeSnapshot(VolumeApiServiceImpl.java:1932)
>         at 
> com.cloud.storage.VolumeApiServiceImpl.orchestrateTakeVolumeSnapshot(VolumeApiServiceImpl.java:2691)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:601)
>         at 
> com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
>         at 
> com.cloud.storage.VolumeApiServiceImpl.handleVmWorkJob(VolumeApiServiceImpl.java:2699)
>         at sun.reflect.GeneratedMethodAccessor489.invoke(Unknown Source)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:601)
>         at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
>         at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>         at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
>         at $Proxy184.handleVmWorkJob(Unknown Source)
>         at 
> com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
>         at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:513)
>         at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
>         at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
>         at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:470)
>         at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>         at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:166)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
>         at java.lang.Thread.run(Thread.java:722)
> Caused by: com.cloud.exception.InvalidParameterValueException: can't handle 
> quiescevm equal true for volume snapshot
>         at 
> org.apache.cloudstack.storage.snapshot.XenserverSnapshotStrategy.takeSnapshot(XenserverSnapshotStrategy.java:270)
>         at 
> com.cloud.storage.snapshot.SnapshotManagerImpl.takeSnapshot(SnapshotManagerImpl.java:971)
>         ... 44 more
> 2014-10-27 18:11:00,634 ERROR [c.c.v.VmWorkJobHandlerProxy] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148 ctx-8ffe0ed1) Invocation 
> exception, caused by: com.cloud.utils.exception.CloudRuntimeException: Failed 
> to take snapshot
> 2014-10-27 18:11:00,635 INFO  [c.c.v.VmWorkJobHandlerProxy] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148 ctx-8ffe0ed1) Rethrow 
> exception com.cloud.utils.exception.CloudRuntimeException: Failed to take 
> snapshot
> 2014-10-27 18:11:00,635 DEBUG [c.c.v.VmWorkJobDispatcher] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148) Done with run of VM work 
> job: com.cloud.storage.VmWorkTakeVolumeSnapshot for VM 14, job origin: 147
> 2014-10-27 18:11:00,636 ERROR [c.c.v.VmWorkJobDispatcher] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148) Unable to complete 
> AsyncJobVO {id:148, userId: 1, accountId: 1, instanceType: null, instanceId: 
> null, cmd: com.cloud.storage.VmWorkTakeVolumeSnapshot, cmdInfo: 
> rO0ABXNyACpjb20uY2xvdWQuc3RvcmFnZS5WbVdvcmtUYWtlVm9sdW1lU25hcHNob3QEvmAbguLVzwIABFoACXF1aWVzY2VWbUwACHBvbGljeUlkdAAQTGphdmEvbGFuZy9Mb25nO0wACnNuYXBzaG90SWRxAH4AAUwACHZvbHVtZUlkcQB-AAF4cgATY29tLmNsb3VkLnZtLlZtV29ya5-ZtlbwJWdrAgAESgAJYWNjb3VudElkSgAGdXNlcklkSgAEdm1JZEwAC2hhbmRsZXJOYW1ldAASTGphdmEvbGFuZy9TdHJpbmc7eHAAAAAAAAAABAAAAAAAAAABAAAAAAAAAA50ABRWb2x1bWVBcGlTZXJ2aWNlSW1wbAFzcgAOamF2YS5sYW5nLkxvbmc7i-SQzI8j3wIAAUoABXZhbHVleHIAEGphdmEubGFuZy5OdW1iZXKGrJUdC5TgiwIAAHhwAAAAAAAAAABzcQB-AAYAAAAAAAAADXNxAH4ABgAAAAAAAAAQ,
>  cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
> null, initMsid: 6637838401571, completeMsid: null, lastUpdated: null, 
> lastPolled: null, created: Mon Oct 27 18:10:59 IST 2014}, job origin:147
> com.cloud.utils.exception.CloudRuntimeException: Failed to take snapshot
>         at 
> org.apache.cloudstack.storage.volume.VolumeServiceImpl.takeSnapshot(VolumeServiceImpl.java:1537)
>         at 
> com.cloud.storage.VolumeApiServiceImpl.orchestrateTakeVolumeSnapshot(VolumeApiServiceImpl.java:1932)
>         at 
> com.cloud.storage.VolumeApiServiceImpl.orchestrateTakeVolumeSnapshot(VolumeApiServiceImpl.java:2691)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:601)
>         at 
> com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
>         at 
> com.cloud.storage.VolumeApiServiceImpl.handleVmWorkJob(VolumeApiServiceImpl.java:2699)
>         at sun.reflect.GeneratedMethodAccessor489.invoke(Unknown Source)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:601)
>         at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
>         at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>         at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
>         at $Proxy184.handleVmWorkJob(Unknown Source)
>         at 
> com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
>         at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:513)
>         at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
>         at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
>         at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:470)
>         at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>         at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:166)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
>         at java.lang.Thread.run(Thread.java:722)
> Caused by: com.cloud.utils.exception.CloudRuntimeException: Failed to create 
> snapshot
>         at 
> com.cloud.storage.snapshot.SnapshotManagerImpl.takeSnapshot(SnapshotManagerImpl.java:988)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:601)
>         at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
>         at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>         at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
>         at $Proxy180.takeSnapshot(Unknown Source)
>         at 
> org.apache.cloudstack.storage.volume.VolumeServiceImpl.takeSnapshot(VolumeServiceImpl.java:1534)
>         ... 32 more
> Caused by: com.cloud.exception.InvalidParameterValueException: can't handle 
> quiescevm equal true for volume snapshot
>         at 
> org.apache.cloudstack.storage.snapshot.XenserverSnapshotStrategy.takeSnapshot(XenserverSnapshotStrategy.java:270)
>         at 
> com.cloud.storage.snapshot.SnapshotManagerImpl.takeSnapshot(SnapshotManagerImpl.java:971)
>         ... 44 more
> 2014-10-27 18:11:00,721 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148) Complete async job-148, 
> jobStatus: FAILED, resultCode: 0, result: 
> rO0ABXNyABpqYXZhLmxhbmcuUnVudGltZUV4Y2VwdGlvbp5fBkcKNIPlAgAAeHIAE2phdmEubGFuZy5FeGNlcHRpb27Q_R8-GjscxAIAAHhyABNqYXZhLmxhbmcuVGhyb3dhYmxl1cY1Jzl3uMsDAARMAAVjYXVzZXQAFUxqYXZhL2xhbmcvVGhyb3dhYmxlO0wADWRldGFpbE1lc3NhZ2V0ABJMamF2YS9sYW5nL1N0cmluZztbAApzdGFja1RyYWNldAAeW0xqYXZhL2xhbmcvU3RhY2tUcmFjZUVsZW1lbnQ7TAAUc3VwcHJlc3NlZEV4Y2VwdGlvbnN0ABBMamF2YS91dGlsL0xpc3Q7eHBxAH4AB3QAM0pvYiBmYWlsZWQgZHVlIHRvIGV4Y2VwdGlvbiBGYWlsZWQgdG8gdGFrZSBzbmFwc2hvdHVyAB5bTGphdmEubGFuZy5TdGFja1RyYWNlRWxlbWVudDsCRio8PP0iOQIAAHhwAAAADnNyABtqYXZhLmxhbmcuU3RhY2tUcmFjZUVsZW1lbnRhCcWaJjbdhQIABEkACmxpbmVOdW1iZXJMAA5kZWNsYXJpbmdDbGFzc3EAfgAETAAIZmlsZU5hbWVxAH4ABEwACm1ldGhvZE5hbWVxAH4ABHhwAAAAcnQAIGNvbS5jbG91ZC52bS5WbVdvcmtKb2JEaXNwYXRjaGVydAAYVm1Xb3JrSm9iRGlzcGF0Y2hlci5qYXZhdAAGcnVuSm9ic3EAfgALAAACAXQAP29yZy5hcGFjaGUuY2xvdWRzdGFjay5mcmFtZXdvcmsuam9icy5pbXBsLkFzeW5jSm9iTWFuYWdlckltcGwkNXQAGEFzeW5jSm9iTWFuYWdlckltcGwuamF2YXQADHJ1bkluQ29udGV4dHNxAH4ACwAAADF0AD5vcmcuYXBhY2hlLmNsb3Vkc3RhY2subWFuYWdlZC5jb250ZXh0Lk1hbmFnZWRDb250ZXh0UnVubmFibGUkMXQAG01hbmFnZWRDb250ZXh0UnVubmFibGUuamF2YXQAA3J1bnNxAH4ACwAAADh0AEJvcmcuYXBhY2hlLmNsb3Vkc3RhY2subWFuYWdlZC5jb250ZXh0LmltcGwuRGVmYXVsdE1hbmFnZWRDb250ZXh0JDF0ABpEZWZhdWx0TWFuYWdlZENvbnRleHQuamF2YXQABGNhbGxzcQB-AAsAAABndABAb3JnLmFwYWNoZS5jbG91ZHN0YWNrLm1hbmFnZWQuY29udGV4dC5pbXBsLkRlZmF1bHRNYW5hZ2VkQ29udGV4dHEAfgAadAAPY2FsbFdpdGhDb250ZXh0c3EAfgALAAAANXEAfgAdcQB-ABp0AA5ydW5XaXRoQ29udGV4dHNxAH4ACwAAAC50ADxvcmcuYXBhY2hlLmNsb3Vkc3RhY2subWFuYWdlZC5jb250ZXh0Lk1hbmFnZWRDb250ZXh0UnVubmFibGVxAH4AFnEAfgAXc3EAfgALAAAB1nEAfgARcQB-ABJxAH4AF3NxAH4ACwAAAdd0AC5qYXZhLnV0aWwuY29uY3VycmVudC5FeGVjdXRvcnMkUnVubmFibGVBZGFwdGVydAAORXhlY3V0b3JzLmphdmFxAH4AG3NxAH4ACwAAAU50ACRqYXZhLnV0aWwuY29uY3VycmVudC5GdXR1cmVUYXNrJFN5bmN0AA9GdXR1cmVUYXNrLmphdmF0AAhpbm5lclJ1bnNxAH4ACwAAAKZ0AB9qYXZhLnV0aWwuY29uY3VycmVudC5GdXR1cmVUYXNrcQB-AClxAH4AF3NxAH4ACwAABFZ0ACdqYXZhLnV0aWwuY29uY3VycmVudC5UaHJlYWRQb29sRXhlY3V0b3J0ABdUaHJlYWRQb29sRXhlY3V0b3IuamF2YXQACXJ1bldvcmtlcnNxAH4ACwAAAlt0AC5qYXZhLnV0aWwuY29uY3VycmVudC5UaHJlYWRQb29sRXhlY3V0b3IkV29ya2VycQB-AC9xAH4AF3NxAH4ACwAAAtJ0ABBqYXZhLmxhbmcuVGhyZWFkdAALVGhyZWFkLmphdmFxAH4AF3NyACZqYXZhLnV0aWwuQ29sbGVjdGlvbnMkVW5tb2RpZmlhYmxlTGlzdPwPJTG17I4QAgABTAAEbGlzdHEAfgAGeHIALGphdmEudXRpbC5Db2xsZWN0aW9ucyRVbm1vZGlmaWFibGVDb2xsZWN0aW9uGUIAgMte9x4CAAFMAAFjdAAWTGphdmEvdXRpbC9Db2xsZWN0aW9uO3hwc3IAE2phdmEudXRpbC5BcnJheUxpc3R4gdIdmcdhnQMAAUkABHNpemV4cAAAAAB3BAAAAAB4cQB-ADt4
> 2014-10-27 18:11:00,731 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148) Publish async job-148 
> complete on message bus
> 2014-10-27 18:11:00,732 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148) Wake up jobs related to 
> job- 148
> 2014-10-27 18:11:00,732 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148) Update db status for job- 
> 148
> 2014-10-27 18:11:00,740 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148) Wake up jobs joined with 
> job- 148 and disjoin all subjobs created from job- 148
> 2014-10-27 18:11:00,755 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-31:ctx-ee1a398a job-147/job-148) Done executing 
> com.cloud.storage.VmWorkTakeVolumeSnapshot for job-148
> 2014-10-27 18:11:00,778 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (API-Job-Executor-44:ctx-15935b7b job-147) Complete async job-147, jobStatus: 
> FAILED, resultCode: 530, result: 
> org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":530,"errortext":"Failed
>  to create snapshot due to an internal error creating snapshot for volume 16"}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to