[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267439#comment-16267439
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10106:
---------------------------------------------

rafaelweingartner commented on a change in pull request #2340: 
CLOUDSTACK-10106: GPU/vGPU Support on VMWare
URL: https://github.com/apache/cloudstack/pull/2340#discussion_r153313840
 
 

 ##########
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##########
 @@ -5101,14 +5209,32 @@ private void fillHostNetworkInfo(VmwareContext 
serviceContext, StartupRoutingCom
         }
     }
 
-    private void fillHostDetailsInfo(VmwareContext serviceContext, Map<String, 
String> details) throws Exception {
+    private void fillHostDetailsInfo(final Map<String, String> details) throws 
Exception {
         VmwareHypervisorHost hyperHost = getHyperHost(getServiceContext());
 
         if (hyperHost.isHAEnabled()) {
             details.put("NativeHA", "true");
         }
     }
 
+    private void fillHostGpuInfo(final StartupRoutingCommand cmd) throws 
Exception {
+        final VmwareContext context = getServiceContext();
+        final VmwareHypervisorHost hyperHost = getHyperHost(context);
+        final HostMO hostMo = new HostMO(context, hyperHost.getMor());
+
+        try {
+            final HashMap<String, HashMap<String, VgpuTypesInfo>> groupDetails 
= hostMo.getGPUGroupDetails();
+            cmd.setGpuGroupDetails(groupDetails);
+            if (groupDetails != null && !groupDetails.isEmpty()) {
+                cmd.setHostTags("GPU");
+            }
+        } catch (final Exception e) {
 
 Review comment:
   Can't we use a more specific exception here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GPU/vGPU Support on VMWare
> --------------------------
>
>                 Key: CLOUDSTACK-10106
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10106
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: API, UI, VMware
>    Affects Versions: 4.11.0.0
>            Reporter: Nitin Kumar Maharana
>              Labels: VMWARE
>             Fix For: 4.11.0.0
>
>
> VMware has added support for NVIDIA GRID K1 and NVIDIA GRID K2 cards as well 
> as NVIDIA Tesla M6 and Tesla M60 cards. This feature allows CloudStack VMs on 
> ESXi hosts to use the GPU cards connected to it. Currently, it supports only 
> NVIDIA GRID K1 and K2 cards for CloudStack VMs.
> Feature Specification: 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74681765



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to