[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268811#comment-16268811
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10054:
---------------------------------------------

rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume 
download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r153505547
 
 

 ##########
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ##########
 @@ -98,28 +98,31 @@
     @Override
     public boolean execute(VmwareHostService hostService, 
CreateEntityDownloadURLCommand cmd) {
         DataTO data = cmd.getData();
+        int timeout = 
NumbersUtil.parseInt(cmd.getContextParam(VmwareManager.s_vmwareOVAPackageTimeout.key()),
 VmwareManagerImpl.DEFAULT_VM_OVA_PACKAGE_TIMEOUT);
 
 Review comment:
   Instead of `DEFAULT_VM_OVA_PACKAGE_TIMEOUT` use the value dynamically by 
calling a method or reading the current value, using the ConfigKey (i.e. 
multiply them). This will enable admins to change value and enforce new 
settings without restarting the mgmt server(s).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Volume download times out in 3600 seconds
> -----------------------------------------
>
>                 Key: CLOUDSTACK-10054
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10054
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: mrunalini
>
> Problem Statement -
> When tried to download a volume of type Vmware with large size, it fails in 
> an hour before generating the URL.
> It can be seen in the ssvm logs that ova generation tar command fails/timed 
> out in an hour. The volume is of 800GB and we should be able to increase the 
> timeout. Unfortunately there is not method to do that. There is no global 
> parameter to update the timeout for this operation.
> Solution
> Add a global parameter 'vmware.backup.session.timeout' for all the tar 
> commands(commands taking long time)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to