[
https://issues.apache.org/jira/browse/CLOUDSTACK-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283392#comment-16283392
]
ASF GitHub Bot commented on CLOUDSTACK-10176:
---------------------------------------------
niteshsarda commented on a change in pull request #2354: CLOUDSTACK-10176:VM
Start Api Job returns success for failed Job
URL: https://github.com/apache/cloudstack/pull/2354#discussion_r155753174
##########
File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4731,7 +4732,8 @@ protected VirtualMachine retrieve() {
}
catch (CloudRuntimeException e){
s_logger.info("Caught CloudRuntimeException, returning job
failed");
- return new Pair<JobInfo.Status, String>(JobInfo.Status.FAILED,
null);
+ CloudRuntimeException ex = new CloudRuntimeException("Unable to
start VM instance : " + e);
+ return new Pair<JobInfo.Status, String>(JobInfo.Status.FAILED,
JobSerializerHelper.toObjectSerializedString(ex));
Review comment:
@rhtyd : Only intention to create a new CloudRuntimeException ex is that
proper error text can be shown to user in the output of startVirtualMachine
API. Following is the output, user will get after this fix :
`2017-12-06 17:11:10,329 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl]
(API-Job-Executor-3:ctx-a8a7ec4b job-355) (logid:92a01680) Complete async
job-355, jobStatus: FAILED, resultCode: 530, result:
org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":530,"**errortext":"Unable
to start VM instance**`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> VM Start Api Job returns success for failed Job
> -----------------------------------------------
>
> Key: CLOUDSTACK-10176
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10176
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Nitesh Sarda
>
> *ISSUE :*
> VM start API Job returns success for failed Job
> *STEPS TO REPRODUCE :*
> # Stop VM instance.
> # Mark state of associate router as Stopping from DB
> # Execute startVirtualMachine Api from rest client.
> # VM will not start but still main job will return the status as SUCCEEDED,
> whereas sub-job for command VmWorkStart will return status as failed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
