[ https://issues.apache.org/jira/browse/CLOUDSTACK-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285886#comment-16285886 ]
ASF GitHub Bot commented on CLOUDSTACK-9986: -------------------------------------------- GabrielBrascher commented on issue #2353: CLOUDSTACK-9986: Use host table to iterate for zone/cluster metrics URL: https://github.com/apache/cloudstack/pull/2353#issuecomment-350723513 Code LGTM. Thanks for the PR, @rhtyd. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Consider overcommit ratios with total/threshold values in Metrics View > ---------------------------------------------------------------------- > > Key: CLOUDSTACK-9986 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9986 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Rohit Yadav > Assignee: Rohit Yadav > Fix For: Future, 4.9.3.0 > > > On code analysis and discussions, I found that overcommit ratios are used > with the allocated values, instead they should be used/compared with the > total/threshold values during comparison for determining where the allocated > values have gone beyond the thresholds (considering overcommit ratios) or not. -- This message was sent by Atlassian JIRA (v6.4.14#64029)