[
https://issues.apache.org/jira/browse/CLOUDSTACK-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292400#comment-16292400
]
ASF GitHub Bot commented on CLOUDSTACK-10176:
---------------------------------------------
rhtyd closed pull request #2354: CLOUDSTACK-10176:VM Start Api Job returns
success for failed Job
URL: https://github.com/apache/cloudstack/pull/2354
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
index fe7fcdfd093..74927b9d465 100755
--- a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
+++ b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -38,6 +38,7 @@
import javax.inject.Inject;
import javax.naming.ConfigurationException;
+import org.apache.cloudstack.framework.jobs.impl.JobSerializerHelper;
import com.cloud.agent.api.AttachOrDettachConfigDriveCommand;
import org.apache.cloudstack.affinity.dao.AffinityGroupVMMapDao;
import org.apache.cloudstack.ca.CAManager;
@@ -4730,8 +4731,9 @@ protected VirtualMachine retrieve() {
orchestrateStart(vm.getUuid(), work.getParams(), work.getPlan(),
_dpMgr.getDeploymentPlannerByName(work.getDeploymentPlanner()));
}
catch (CloudRuntimeException e){
- s_logger.info("Caught CloudRuntimeException, returning job
failed");
- return new Pair<JobInfo.Status, String>(JobInfo.Status.FAILED,
null);
+ s_logger.info("Caught CloudRuntimeException, returning job failed
" + e);
+ CloudRuntimeException ex = new CloudRuntimeException("Unable to
start VM instance");
+ return new Pair<JobInfo.Status, String>(JobInfo.Status.FAILED,
JobSerializerHelper.toObjectSerializedString(ex));
}
return new Pair<JobInfo.Status, String>(JobInfo.Status.SUCCEEDED,
null);
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> VM Start Api Job returns success for failed Job
> -----------------------------------------------
>
> Key: CLOUDSTACK-10176
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10176
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Nitesh Sarda
>
> *ISSUE :*
> VM start API Job returns success for failed Job
> *STEPS TO REPRODUCE :*
> # Stop VM instance.
> # Mark state of associate router as Stopping from DB
> # Execute startVirtualMachine Api from rest client.
> # VM will not start but still main job will return the status as SUCCEEDED,
> whereas sub-job for command VmWorkStart will return status as failed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
