[
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299952#comment-16299952
]
ASF GitHub Bot commented on CLOUDSTACK-10024:
---------------------------------------------
rhtyd commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r158266530
##########
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtReplugNicCommandWrapper.java
##########
@@ -0,0 +1,133 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import java.util.List;
+
+import org.apache.log4j.Logger;
+import org.libvirt.Connect;
+import org.libvirt.Domain;
+import org.libvirt.LibvirtException;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.ReplugNicAnswer;
+import com.cloud.agent.api.ReplugNicCommand;
+import com.cloud.agent.api.to.NicTO;
+import com.cloud.exception.InternalErrorException;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.InterfaceDef;
+import com.cloud.hypervisor.kvm.resource.VifDriver;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+
+@ResourceWrapper(handles = ReplugNicCommand.class)
+public final class LibvirtReplugNicCommandWrapper extends
CommandWrapper<ReplugNicCommand, Answer, LibvirtComputingResource> {
+
+ private static final Logger s_logger =
Logger.getLogger(LibvirtReplugNicCommandWrapper.class);
+ public enum DomainAffect {
+ CURRENT(0), LIVE(1), CONFIG(2), BOTH(3);
+
+ private int value;
+ DomainAffect(int value) {
+ this.value = value;
+ }
+
+ public int getValue() {
+ return value;
+ }
+ }
+
+ @Override
+ public Answer execute(final ReplugNicCommand command, final
LibvirtComputingResource libvirtComputingResource) {
+ final NicTO nic = command.getNic();
+ final String vmName = command.getVmName();
+ Domain vm = null;
+ try {
+ final LibvirtUtilitiesHelper libvirtUtilitiesHelper =
libvirtComputingResource.getLibvirtUtilitiesHelper();
+ final Connect conn =
libvirtUtilitiesHelper.getConnectionByVmName(vmName);
+ vm = libvirtComputingResource.getDomain(conn, vmName);
+
+ InterfaceDef oldPluggedNic =
findPluggedNic(libvirtComputingResource, nic, vmName, conn);
+
+ final VifDriver newVifDriver =
libvirtComputingResource.getVifDriver(nic.getType(), nic.getName());
+ final InterfaceDef interfaceDef = newVifDriver.plug(nic, "Other
PV", oldPluggedNic.getModel().toString());
+
+ interfaceDef.setSlot(oldPluggedNic.getSlot());
+ interfaceDef.setDevName(oldPluggedNic.getDevName());
+ interfaceDef.setLinkStateUp(false);
+
+ oldPluggedNic.setSlot(null);
+
+ int i = 0;
+ do {
+ i++;
+ s_logger.debug("ReplugNic: Detaching interface" +
oldPluggedNic + " (Attempt: " + i + ")");
+ vm.detachDevice(oldPluggedNic.toString());
+ } while (findPluggedNic(libvirtComputingResource, nic, vmName,
conn) != null && i <= 10);
+
+ s_logger.debug("ReplugNic: Attaching interface" + interfaceDef);
+ vm.attachDevice(interfaceDef.toString());
+
+ interfaceDef.setLinkStateUp(true);
+ s_logger.debug("ReplugNic: Updating interface" + interfaceDef);
+ vm.updateDeviceFlags(interfaceDef.toString(),
DomainAffect.LIVE.getValue());
+
+ /*
+ // Manual replug
Review comment:
Dead code could be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Physical Networking Migration
> -----------------------------
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API, KVM, Management Server, VMware
> Reporter: Frank Maximus
> Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network
> infrastructure
> *In order to* leverage new network technologies, e.g. leverage SDN.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
