[
https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302554#comment-16302554
]
ASF GitHub Bot commented on CLOUDSTACK-10109:
---------------------------------------------
nvazquez commented on a change in pull request #2295: CLOUDSTACK-10109: Enable
dedication of public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#discussion_r158588248
##########
File path: server/src/com/cloud/network/guru/PublicNetworkGuru.java
##########
@@ -115,7 +115,11 @@ protected PublicNetworkGuru() {
protected void getIp(NicProfile nic, DataCenter dc, VirtualMachineProfile
vm, Network network) throws InsufficientVirtualNetworkCapacityException,
InsufficientAddressCapacityException, ConcurrentOperationException {
if (nic.getIPv4Address() == null) {
- PublicIp ip = _ipAddrMgr.assignPublicIpAddress(dc.getId(), null,
vm.getOwner(), VlanType.VirtualNetwork, null, null, false);
+ boolean forSystemVms = false;
+ if (vm.getType().equals(VirtualMachine.Type.ConsoleProxy) ||
vm.getType().equals(VirtualMachine.Type.SecondaryStorageVm)) {
+ forSystemVms = true;
Review comment:
@nitin-maharana sorry for late response, been busy with other tasks. I
checked usage of is_system column and are used for static nat or load balancing
purposes. Best option should be including this new column.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable dedication of public IPs to SSVM and CPVM
> ------------------------------------------------
>
> Key: CLOUDSTACK-10109
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Nicolas Vazquez
> Assignee: Nicolas Vazquez
> Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to
> apply firewall rules to control inbound access.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
