[
https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303154#comment-16303154
]
ASF GitHub Bot commented on CLOUDSTACK-9572:
--------------------------------------------
yvsubhash commented on a change in pull request #1740: CLOUDSTACK-9572 Snapshot
on primary storage not cleaned up after Stor…
URL: https://github.com/apache/cloudstack/pull/1740#discussion_r158631798
##########
File path:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotDataFactoryImpl.java
##########
@@ -64,6 +64,24 @@ public SnapshotInfo getSnapshot(DataObject obj, DataStore
store) {
return so;
}
+ @Override
+ public List<SnapshotInfo> getSnapshots(long volumeId, DataStoreRole role) {
+
+ SnapshotDataStoreVO snapshotStore =
snapshotStoreDao.findByVolume(volumeId, role);
+ if (snapshotStore == null) {
+ return null;
Review comment:
@rafaelweingartner Deleting snapshots from primary after copy is complete
taken care in xenserver case in postSnapshotCreation method in
XenserverSnapshotStrategy.java for all snapshots except the lost one. So this
one only takes care of the last snapshot that we keep in primary for delta
snapshots. null return is replaced with empty set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Snapshot on primary storage not cleaned up after Storage migration
> ------------------------------------------------------------------
>
> Key: CLOUDSTACK-9572
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Storage Controller
> Affects Versions: 4.8.0
> Environment: Xen Server
> Reporter: subhash yedugundla
> Fix For: 4.8.1
>
>
> Issue Description
> ===============
> 1. Create an instance on the local storage on any host
> 2. Create a scheduled snapshot of the volume:
> 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local
> storage and is transferring this snapshot to secondary storage. But the
> latest snapshot on local storage will stay there. This is as expected.
> 4. Migrate the instance to another XenServer host with ACS UI and Storage
> Live Migration
> 5. The Snapshot on the old host on local storage will not be cleaned up and
> is staying on local storage. So local storage will fill up with unneeded
> snapshots.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
