[
https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307912#comment-16307912
]
ASF GitHub Bot commented on CLOUDSTACK-10108:
---------------------------------------------
rhtyd commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for
reading 'ping' configua…
URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-354748996
@mrunalinikankariya no, not without regression tests. Please also see the
left comments specifically around refactoring the code. Thanks.
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ConfigKey based approach for reading 'ping' configuaration for Management
> Server
> --------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10108
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: mrunalini
> Priority: Minor
>
> In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using
> configdao which involves direct reading of DB. So, replace it with ConfigKey
> based approach
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
