[
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311242#comment-16311242
]
ASF GitHub Bot commented on CLOUDSTACK-4757:
--------------------------------------------
rafaelweingartner commented on issue #2146: CLOUDSTACK-4757: Support OVA files
with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355263035
@DaanHoogland now that you saw the other remarks, the cyclomatic complexity
is one issue for sure (most people overlook this, and this is one of the causes
of our 1000+ lines methods). There are the others issues that we will probably
ignore here, which are the excessive catch of generic exceptions (there is even
a catch Throwable… this style of working is one of the causes of those nasty
bugs that we sometimes spend hours and days debugging), the manual parse of XML
(this trait of manually doing things and not adopting consolidated libraries is
one of the causes of excessive code in our code base), and so on.
To reinforce what I said before, I raise issues to discuss and to try
improving the work that is being proposed. I really do not see the benefit to
go to a PR, use my time to go over it and not have an opinion (a critique) to
make about it. I would feel like wasting my time then. Also, I do not see the
point in requiring a review, if it is to go to PRs and just saying LGTM just to
mark a requirement of a protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support OVA files with multiple disks for templates
> ---------------------------------------------------
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Storage Controller
> Reporter: Likitha Shetty
> Assignee: Nicolas Vazquez
> Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of
> XenServer/XCP and KVM hypervisors since the files used for templates and
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates
> are in OVA format, which are archives that can contain a complete VM
> including multiple VMDKs and other files such as ISOs. And currently,
> Cloudstack only supports Template creation based on OVA files containing a
> single disk. If a user creates a template from a OVA file containing more
> than 1 disk and launches an instance using this template, only the first disk
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains
> multiple disks to a VM will result in only one VMDK to being attached to the
> VM.
> This behavior needs to be improved in VMWare to support OVA files with
> multiple disks for both uploaded volumes and templates. i.e. If a user
> creates a template from a OVA file containing more than 1 disk and launches
> an instance using this template, the first disk should be attached to the new
> instance as the ROOT disk and volumes should be created based on other VMDK
> disks in the OVA file and should be attached to the instance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
