[
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313130#comment-16313130
]
ASF GitHub Bot commented on CLOUDSTACK-10146:
---------------------------------------------
rafaelweingartner commented on a change in pull request #2379:
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878648
##########
File path:
agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
##########
@@ -0,0 +1,188 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.utils.script.Script;
+import org.apache.cloudstack.utils.security.ChecksumValue;
+import org.apache.commons.lang.StringUtils;
+
+import java.io.File;
+import java.util.UUID;
+
+public abstract class DirectTemplateDownloaderImpl implements
DirectTemplateDownloader {
+
+ private String url;
+ private String destPoolPath;
+ private Long templateId;
+ private String downloadedFilePath;
+ private String installPath;
+ private String checksum;
+
+ protected DirectTemplateDownloaderImpl(final String url, final String
destPoolPath, final Long templateId, final String checksum) {
+ this.url = url;
+ this.destPoolPath = destPoolPath;
+ this.templateId = templateId;
+ this.checksum = checksum;
+ }
+
+ private static String directDownloadDir = "template";
+
+ /**
+ * Return direct download temporary path to download template
+ * @param templateId
+ * @return
+ */
+ protected static String getDirectDownloadTempPath(Long templateId) {
+ String templateIdAsString = String.valueOf(templateId);
+ return directDownloadDir + File.separator +
templateIdAsString.substring(0,1) +
+ File.separator + templateIdAsString;
+ }
+
+ /**
+ * Create folder on path if it does not exist
+ * @param path
Review comment:
@param can be removed from here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bypass Secondary Storage for KVM templates
> ------------------------------------------
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.11.0.0
> Reporter: Nicolas Vazquez
> Assignee: Nicolas Vazquez
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
