[
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318387#comment-16318387
]
ASF GitHub Bot commented on CLOUDSTACK-9813:
--------------------------------------------
krissterckx commented on a change in pull request #2097: [4.11]
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160401714
##########
File path: tools/marvin/marvin/config/test_data.py
##########
@@ -513,6 +565,19 @@
"NetworkACL": 'VpcVirtualRouter'
}
},
+ "vpc_offering_configdrive": {
+ "name": 'VPC offering ConfigDrive',
+ "displaytext": 'VPC offering ConfigDrive',
+ "supportedservices":
'Dhcp,StaticNat,SourceNat,NetworkACL,UserData,Dns',
+ "serviceProviderList": {
+ "Dhcp": "VpcVirtualRouter",
+ "StaticNat": "VpcVirtualRouter",
+ "SourceNat": "VpcVirtualRouter",
+ "NetworkACL": "VpcVirtualRouter",
+ "UserData": "ConfigDrive",
+ "Dns": "VpcVirtualRouter"
+ }
+ },
Review comment:
@rhtyd are you saying that even for new generic component tests that are
added (see test_configdrive.py being added), the policy is to add offering to
the test itself rather than extending test_data , even when config drive
becomes a new generic capability, added by this PR ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use configdrive for userdata, metadata & password
> --------------------------------------------------
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: KVM, Network Controller, Secondary Storage, SystemVM,
> VMware
> Affects Versions: Future
> Reporter: Eric Waegeman
> Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement
> configdrive for userdata, metadata & password.
> The configdrive ISO is created on the secondary store and the KVM & VMware
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
