[
https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342055#comment-16342055
]
ASF GitHub Bot commented on CLOUDSTACK-10225:
---------------------------------------------
rafaelweingartner commented on a change in pull request #2431:
CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons
URL: https://github.com/apache/cloudstack/pull/2431#discussion_r164267987
##########
File path: utils/src/main/java/com/cloud/utils/StringUtils.java
##########
@@ -78,12 +76,13 @@ public static String join(final String delimiter, final
Object... components) {
return org.apache.commons.lang.StringUtils.join(components, delimiter);
}
+ /**
+ * @deprecated
+ * Please use org.apache.commons.lang.StringUtils.IsBlank() as a
replacement
Review comment:
What about referencing `org.apache.commons.lang.StringUtils.IsNotBlank`
instead? So, we do not cause confusions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate com.cloud.utils.StringUtils
> -------------------------------------
>
> Key: CLOUDSTACK-10225
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Wido den Hollander
> Priority: Major
>
> com.cloud.utils.StringUtils contains a lot of methods which can be deprecated
> in favor of Apache Commons.
> We should try to use Apache Commons where possible and reduce our code
> footprint.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
