[
https://issues.apache.org/jira/browse/CLOUDSTACK-9338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349690#comment-16349690
]
ASF GitHub Bot commented on CLOUDSTACK-9338:
--------------------------------------------
bwsw commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting
resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-362467046
@rafaelweingartner
Thank you commiting to this area of code. Proper accounting is very
important, I commited in 4.11 regarding accounting too, but it seems there are
a lot of possible bugs happen here.
Nb. Please keep in mind to check that domain resources are accounted
correctly too. Also, I strongly believe resources should be updated with
increment/decrement merhods, but updateResourceCount is only should be used to
do periodic update for top level domains when a/b/c/account is used and we
would like to update for b and a...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> updateResourceCount not accounting resources of VMs with custom service
> offering
> --------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9338
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9338
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API, Cloudmonkey, UI
> Affects Versions: 4.5.2, 4.8.0
> Environment: CloudStack 4.5.1
> MariaDB 10.0 and 10.1
> Reporter: Francois Scheurer
> Assignee: Rafael Weingärtner
> Priority: Major
>
> listAccount on a domain returns 0 for cputotal and memorytotal if the domain
> accounts own VMs using a ComputeOffering with custom=enabled.
> Basically, looking into the vm_instance table you get the service_offering_id
> and in the service_offering table you find normally the amount of CPU/RAM
> allocated for the VM.
> But if your VM's ComputeOffering has custom=enabled, then you need to get the
> specific CPU/RAM values from the user_vm_details table:
> mysql> select * from user_vm_details WHERE vm_id=957;
> Apparently the listAccount code is not doing that and it just returns zero,
> because the service_offering table has cpu=0 and ram_size=0 for
> ComputeOfferings with custom=enabled.
> solution: the SQL query of listAccount should also look in the
> user_vm_details table for matching rows. (instead of just querying in the
> service_offering table)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
