[
https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371298#comment-16371298
]
ASF GitHub Bot commented on CLOUDSTACK-10299:
---------------------------------------------
resmo commented on a change in pull request #2464: [4.11] CLOUDSTACK-10299: UI:
fix error in network listing in project mode
URL: https://github.com/apache/cloudstack/pull/2464#discussion_r169617346
##########
File path: ui/scripts/network.js
##########
@@ -3537,28 +3535,28 @@
var lbID =
data.createloadbalancerruleresponse.id;
var inputData = {
- id:
data.createloadbalancerruleresponse.id
- };
-
+ id:
data.createloadbalancerruleresponse.id
+ };
+
var selectedVMs =
args.itemData;
if (selectedVMs !=
null) {
var
vmidipmapIndex = 0;
- for (var
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {
+ for (var
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {
var
selectedIPs = selectedVMs[vmIndex]._subselect;
for
(var ipIndex = 0; ipIndex < selectedIPs.length; ipIndex++) {
inputData['vmidipmap[' + vmidipmapIndex + '].vmid'] = selectedVMs[vmIndex].id;
-
+
if (args.context.ipAddresses[0].isportable) {
-
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] =
selectedIPs[ipIndex].split(',')[1];
+
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] =
selectedIPs[ipIndex].split(',')[1];
} else {
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] =
selectedIPs[ipIndex];
}
-
+
vmidipmapIndex++;
- }
+ }
}
- }
-
+ }
+
/*$.ajax({
Review comment:
I see your point. cleaning up commented out code makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Network listing return error in project mode
> --------------------------------------------
>
> Key: CLOUDSTACK-10299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10299
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: UI
> Affects Versions: 4.11.0.0
> Reporter: René Moser
> Priority: Minor
> Attachments: Selection_142.png
>
>
> {{Clicking the network button in a project returns the following error:}}
>
> {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Account}}{{
> and projectId can't be specified together"}}}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
