[
https://issues.apache.org/jira/browse/CLOUDSTACK-10283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382086#comment-16382086
]
ASF GitHub Bot commented on CLOUDSTACK-10283:
---------------------------------------------
rhtyd commented on a change in pull request #2454: CLOUDSTACK-10283: Sudo to
setup agent keystore, fail on host add failure
URL: https://github.com/apache/cloudstack/pull/2454#discussion_r171580645
##########
File path: agent/src/com/cloud/agent/Agent.java
##########
@@ -647,7 +647,7 @@ public Answer setupAgentKeystore(final
SetupKeyStoreCommand cmd) {
_shell.setPersistentProperty(null,
KeyStoreUtils.passphrasePropertyName, storedPassword);
}
- Script script = new Script(_keystoreSetupPath, 60000, s_logger);
+ Script script = new Script(true, _keystoreSetupPath, 60000, s_logger);
Review comment:
@krissterckx this runs the script with sudo (when true is passed). It allows
admins to add a KVM host using a non-root sudoer user (see for details
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Allow+non-root+user+to+add+KVM+hypervisor)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use sudo to execute keystore setup/import for kvm agents, and fail on
> keystore setup failures
> ---------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10283
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10283
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rohit Yadav
> Assignee: Rohit Yadav
> Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> Addition of a KVM host creates keystore on the KVM host's
> /etc/cloudstack/agent path. The current scripts and codebase assumes that it
> will be the root user which is why the script don't call keytool with 'sudo'.
> To allow addition of host using a sudo-enabled/admin user, make suitable
> changes to the script, and also fail the addHost execution if keystore
> scripts fail (say due to permission issues etc).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
