[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387628#comment-16387628
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10318:
---------------------------------------------

rafaelweingartner closed pull request #2478: [CLOUDSTACK-10318] Bug on sorting 
ACL rules list in chrome
URL: https://github.com/apache/cloudstack/pull/2478
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ui/scripts/vpc.js b/ui/scripts/vpc.js
index 9dc8323e7cd..a77c4d7b585 100644
--- a/ui/scripts/vpc.js
+++ b/ui/scripts/vpc.js
@@ -1325,7 +1325,7 @@
 
                                                     if(items){
                                                         items.sort(function(a, 
b) {
-                                                            return a.number >= 
b.number;
+                                                            return a.number - 
b.number;
                                                         }).map(function(acl) {
                                                             if 
(parseInt(acl.protocol)) { // protocol number
                                                                 
acl.protocolnumber = acl.protocol;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bug on sorting ACL rules list in chrome 
> ----------------------------------------
>
>                 Key: CLOUDSTACK-10318
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10318
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Rafael Weingärtner
>            Assignee: Rafael Weingärtner
>            Priority: Major
>             Fix For: 4.12
>
>
> There is a bug on ACL rules list when a user creates more than 10 rules.
> #Steps to reproduce this issue
> - Create more than 10 ACL rules.
> - Access the ACL rules list page.
> - You will see that they are not sorted as they should by the ACL rule number



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to